[PR #2566] [MERGED] More modularization of DNSSEC crypto code #3144

New issue

Closed

opened 2026-03-16 11:27:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:27:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2566
Author: @djc
Created: 11/10/2024
Status: ✅ Merged
Merged: 11/17/2024
Merged by: @djc

Base: main ← Head: dnssec-module

📝 Commits (7)

5fcf75a proto: hoist dnssec module up one level
22e20bd proto: remove unnecessary trait shims
3aeb09e proto: move SigningKey trait and decode_key() into dnssec root module
b1cf37d proto: create separate modules for ring and openssl
a17872b proto: only export backend-specific implementations via specific modules
bfe377a proto: avoid silently defaulting to SHA512
cd3fc8c proto: narrow DigestType definition to make conversions infallible

📊 Changes

79 files changed (+576 additions, -633 deletions)

View changed files

📝 bin/src/dnssec.rs (+3 -3)
📝 bin/src/hickory-dns.rs (+2 -3)
📝 bin/tests/integration/authority_battery/dnssec.rs (+5 -7)
📝 bin/tests/integration/authority_battery/dynamic_update.rs (+4 -4)
📝 bin/tests/integration/config_tests.rs (+1 -1)
📝 bin/tests/integration/named_test_rsa_dnssec.rs (+4 -2)
📝 bin/tests/integration/server_harness/mod.rs (+6 -3)
📝 crates/client/src/client/dnssec_client.rs (+1 -1)
📝 crates/proto/src/dnssec/algorithm.rs (+0 -0)
📝 crates/proto/src/dnssec/digest_type.rs (+28 -38)
📝 crates/proto/src/dnssec/ec_public_key.rs (+0 -0)
📝 crates/proto/src/dnssec/key_format.rs (+3 -4)
➕ crates/proto/src/dnssec/mod.rs (+188 -0)
📝 crates/proto/src/dnssec/nsec3.rs (+0 -0)
📝 crates/proto/src/dnssec/openssl.rs (+9 -292)
📝 crates/proto/src/dnssec/proof.rs (+2 -2)
📝 crates/proto/src/dnssec/public_key.rs (+2 -2)
📝 crates/proto/src/dnssec/rdata/cdnskey.rs (+0 -0)
📝 crates/proto/src/dnssec/rdata/cds.rs (+0 -0)
📝 crates/proto/src/dnssec/rdata/dnskey.rs (+2 -5)

...and 59 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2566 **Author:** [@djc](https://github.com/djc) **Created:** 11/10/2024 **Status:** ✅ Merged **Merged:** 11/17/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dnssec-module` --- ### 📝 Commits (7) - [`5fcf75a`](https://github.com/hickory-dns/hickory-dns/commit/5fcf75a1121848e22fb4c894c278a9186eeedb71) proto: hoist dnssec module up one level - [`22e20bd`](https://github.com/hickory-dns/hickory-dns/commit/22e20bd874cc970fc335490013a268a9eac61cd7) proto: remove unnecessary trait shims - [`3aeb09e`](https://github.com/hickory-dns/hickory-dns/commit/3aeb09eee4b297d735ddf83454eaadec298374bb) proto: move SigningKey trait and decode_key() into dnssec root module - [`b1cf37d`](https://github.com/hickory-dns/hickory-dns/commit/b1cf37d2c9d9bfbec5cdf85260122610e0d51f09) proto: create separate modules for ring and openssl - [`a17872b`](https://github.com/hickory-dns/hickory-dns/commit/a17872b711338a5e23447a020350c209506ebc8e) proto: only export backend-specific implementations via specific modules - [`bfe377a`](https://github.com/hickory-dns/hickory-dns/commit/bfe377acec90a6676e1f7bff85efb46140b566f9) proto: avoid silently defaulting to SHA512 - [`cd3fc8c`](https://github.com/hickory-dns/hickory-dns/commit/cd3fc8c18557430427c8d7d7374f75c0c1af1de8) proto: narrow DigestType definition to make conversions infallible ### 📊 Changes **79 files changed** (+576 additions, -633 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/dnssec.rs` (+3 -3) 📝 `bin/src/hickory-dns.rs` (+2 -3) 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+5 -7) 📝 `bin/tests/integration/authority_battery/dynamic_update.rs` (+4 -4) 📝 `bin/tests/integration/config_tests.rs` (+1 -1) 📝 `bin/tests/integration/named_test_rsa_dnssec.rs` (+4 -2) 📝 `bin/tests/integration/server_harness/mod.rs` (+6 -3) 📝 `crates/client/src/client/dnssec_client.rs` (+1 -1) 📝 `crates/proto/src/dnssec/algorithm.rs` (+0 -0) 📝 `crates/proto/src/dnssec/digest_type.rs` (+28 -38) 📝 `crates/proto/src/dnssec/ec_public_key.rs` (+0 -0) 📝 `crates/proto/src/dnssec/key_format.rs` (+3 -4) ➕ `crates/proto/src/dnssec/mod.rs` (+188 -0) 📝 `crates/proto/src/dnssec/nsec3.rs` (+0 -0) 📝 `crates/proto/src/dnssec/openssl.rs` (+9 -292) 📝 `crates/proto/src/dnssec/proof.rs` (+2 -2) 📝 `crates/proto/src/dnssec/public_key.rs` (+2 -2) 📝 `crates/proto/src/dnssec/rdata/cdnskey.rs` (+0 -0) 📝 `crates/proto/src/dnssec/rdata/cds.rs` (+0 -0) 📝 `crates/proto/src/dnssec/rdata/dnskey.rs` (+2 -5) _...and 59 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>