[PR #1748] [MERGED] Clean up ForwardAuthority api #2566

New issue

Closed

opened 2026-03-16 10:12:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:12:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1748
Author: @chotchki
Created: 7/30/2022
Status: ✅ Merged
Merged: 8/1/2022
Merged by: @djc

Base: main ← Head: forward_authority_async

📝 Commits (1)

3c03ed5 Removed async from the ForwardAuthority functions new and try_from_config.

📊 Changes

3 files changed (+9 additions, -11 deletions)

View changed files

📝 bin/src/named.rs (+2 -3)
📝 crates/server/src/store/forwarder/authority.rs (+2 -2)
📝 crates/server/tests/forwarder.rs (+5 -6)

📄 Description

I removed async from ForwardAuthority's new and try_from_config methods.

Neither of them have any await calls so async adds a future layer for no benefit. Tests were adjusted to account for this too.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1748 **Author:** [@chotchki](https://github.com/chotchki) **Created:** 7/30/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `forward_authority_async` --- ### 📝 Commits (1) - [`3c03ed5`](https://github.com/hickory-dns/hickory-dns/commit/3c03ed53a86af3599025e85fb3f54464b4fae990) Removed async from the ForwardAuthority functions new and try_from_config. ### 📊 Changes **3 files changed** (+9 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/named.rs` (+2 -3) 📝 `crates/server/src/store/forwarder/authority.rs` (+2 -2) 📝 `crates/server/tests/forwarder.rs` (+5 -6) </details> ### 📄 Description I removed async from ForwardAuthority's new and try_from_config methods. Neither of them have any await calls so async adds a future layer for no benefit. Tests were adjusted to account for this too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>