[PR #2556] [MERGED] fix key tag collision issue in zone signer #3138

Closed
opened 2026-03-16 11:27:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2556
Author: @marcus0x62
Created: 11/5/2024
Status: Merged
Merged: 11/13/2024
Merged by: @djc

Base: mainHead: dnstest-ksk-issue


📝 Commits (1)

  • 204e165 Work around collision issue in ldns-signzone

📊 Changes

1 file changed (+17 additions, -3 deletions)

View changed files

📝 conformance/packages/dns-test/src/zone_file/signer.rs (+17 -3)

📄 Description

This fixes an issue where key tag collisions between the generated KSK and ZSKs could cause intermittent test failures, triggered by a (bug?) in ldns-signzone. See discussion in #2555.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2556 **Author:** [@marcus0x62](https://github.com/marcus0x62) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `dnstest-ksk-issue` --- ### 📝 Commits (1) - [`204e165`](https://github.com/hickory-dns/hickory-dns/commit/204e165507a9cc56a3ccfe9f4eb9f9dbc68ef5b0) Work around collision issue in ldns-signzone ### 📊 Changes **1 file changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/zone_file/signer.rs` (+17 -3) </details> ### 📄 Description This fixes an issue where key tag collisions between the generated KSK and ZSKs could cause intermittent test failures, triggered by a (bug?) in ldns-signzone. See discussion in #2555. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 11:27:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#3138
No description provided.