[PR #1736] [MERGED] proto: Increase the maximum request depth to 26 #2556

New issue

Closed

opened 2026-03-16 10:11:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:11:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1736
Author: @wiktor-k
Created: 7/12/2022
Status: ✅ Merged
Merged: 7/12/2022
Merged by: @bluejekyll

Base: main ← Head: increase-max-request-depth

📝 Commits (1)

f3a3780 proto: Increase the maximum request depth to 26

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 crates/proto/src/xfer/dnssec_dns_handle.rs (+1 -1)

📄 Description

OPENPGPKEY requests in the wild has been found to exceed the maximum request depth (20) partially due to parallel requests that increase the counter by 2 or 4.

Increasing the value to 26 allows these requests to succeed. The test vector used to validate this change is a validating request for OPENPGPKEY records for the following name:

A47CB586A51ACB93ACB9EF806F35F29131548E59E2FACD58CF6232E3._openpgpkey.debian.org

See: https://github.com/bluejekyll/trust-dns/issues/1735

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1736 **Author:** [@wiktor-k](https://github.com/wiktor-k) **Created:** 7/12/2022 **Status:** ✅ Merged **Merged:** 7/12/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `increase-max-request-depth` --- ### 📝 Commits (1) - [`f3a3780`](https://github.com/hickory-dns/hickory-dns/commit/f3a378066f8277659691972ae2bc73d4e1395e43) proto: Increase the maximum request depth to 26 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/xfer/dnssec_dns_handle.rs` (+1 -1) </details> ### 📄 Description OPENPGPKEY requests in the wild has been found to exceed the maximum request depth (20) partially due to parallel requests that increase the counter by 2 or 4. Increasing the value to 26 allows these requests to succeed. The test vector used to validate this change is a validating request for OPENPGPKEY records for the following name: A47CB586A51ACB93ACB9EF806F35F29131548E59E2FACD58CF6232E3._openpgpkey.debian.org See: https://github.com/bluejekyll/trust-dns/issues/1735 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>