[PR #2549] [MERGED] proto: encode EDNS flags in a separate type #3125

New issue

Closed

opened 2026-03-16 11:26:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:26:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2549
Author: @djc
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @djc

Base: main ← Head: edns-flags

📝 Commits (2)

26bb3cd proto: move Edns test into tests module
3692452 proto: encode EDNS flags in a separate type

📊 Changes

6 files changed (+106 additions, -86 deletions)

View changed files

📝 crates/proto/src/op/edns.rs (+86 -72)
📝 crates/proto/src/op/mod.rs (+1 -1)
📝 crates/server/src/authority/catalog.rs (+1 -1)
📝 crates/server/src/server/server_future.rs (+2 -2)
📝 tests/integration-tests/tests/integration/client_tests.rs (+8 -5)
📝 tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs (+8 -5)

📄 Description

See discussion in https://github.com/hickory-dns/hickory-dns/pull/2544#discussion_r1825947897.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2549 **Author:** [@djc](https://github.com/djc) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `edns-flags` --- ### 📝 Commits (2) - [`26bb3cd`](https://github.com/hickory-dns/hickory-dns/commit/26bb3cd532ae8d5acc1ca622b719d0279897f06d) proto: move Edns test into tests module - [`3692452`](https://github.com/hickory-dns/hickory-dns/commit/36924523534d6a6e5f54e64433ce48e188153016) proto: encode EDNS flags in a separate type ### 📊 Changes **6 files changed** (+106 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/edns.rs` (+86 -72) 📝 `crates/proto/src/op/mod.rs` (+1 -1) 📝 `crates/server/src/authority/catalog.rs` (+1 -1) 📝 `crates/server/src/server/server_future.rs` (+2 -2) 📝 `tests/integration-tests/tests/integration/client_tests.rs` (+8 -5) 📝 `tests/integration-tests/tests/integration/dnssec_client_handle_tests.rs` (+8 -5) </details> ### 📄 Description See discussion in https://github.com/hickory-dns/hickory-dns/pull/2544#discussion_r1825947897. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>