[PR #1727] [CLOSED] Mark ForwardLookup as public #2549

New issue

Closed

opened 2026-03-16 10:07:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 10:07:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1727
Author: @chotchki
Created: 6/23/2022
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (8)

90c9e58 Mark ForwardLookup as public
2014523 Adding documentation for the new public interface
b8fd92a upgrade windows openssl version to 1_1_1p
126d714 Fixed grammer and forcing a repush post the openssl upgrade
091cf78 Mark ForwardLookup as public
d2c9b84 Adding documentation for the new public interface
be8fb34 Fixed grammer and forcing a repush post the openssl upgrade
18c60b7 Merge branch 'patch-1' of https://github.com/chotchki/trust-dns into patch-1

📊 Changes

3 files changed (+5 additions, -1 deletions)

View changed files

📝 Makefile.toml (+1 -1)
📝 crates/server/src/store/forwarder/authority.rs (+3 -0)
📝 crates/server/src/store/forwarder/mod.rs (+1 -0)

📄 Description

I am trying to implement a wrapper around ForwardAuthority so I can intercept for rewriting/auditing what a dns forwarder produces. However implementing a wrapper is extremely challenging without ForwardLookup also being public.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1727 **Author:** [@chotchki](https://github.com/chotchki) **Created:** 6/23/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (8) - [`90c9e58`](https://github.com/hickory-dns/hickory-dns/commit/90c9e58add8d470107e09593a9829e69263bc8d7) Mark ForwardLookup as public - [`2014523`](https://github.com/hickory-dns/hickory-dns/commit/2014523310c6bb46c82aaab3e22babd7fd59507f) Adding documentation for the new public interface - [`b8fd92a`](https://github.com/hickory-dns/hickory-dns/commit/b8fd92afbb0b25f8bbfaf0644a2630009923cddf) upgrade windows openssl version to 1_1_1p - [`126d714`](https://github.com/hickory-dns/hickory-dns/commit/126d7143b9a68244d4d557a7861ce6d5d2fd7ea6) Fixed grammer and forcing a repush post the openssl upgrade - [`091cf78`](https://github.com/hickory-dns/hickory-dns/commit/091cf786bbd1bee32c9b82c6f29b8d14a9c80fd7) Mark ForwardLookup as public - [`d2c9b84`](https://github.com/hickory-dns/hickory-dns/commit/d2c9b846cb8bc320986feb9927d78e6604ff1aba) Adding documentation for the new public interface - [`be8fb34`](https://github.com/hickory-dns/hickory-dns/commit/be8fb349f57cd92909501b550a2478865c4d2766) Fixed grammer and forcing a repush post the openssl upgrade - [`18c60b7`](https://github.com/hickory-dns/hickory-dns/commit/18c60b7d692d148478068a4f009e8e54d7cbf35e) Merge branch 'patch-1' of https://github.com/chotchki/trust-dns into patch-1 ### 📊 Changes **3 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.toml` (+1 -1) 📝 `crates/server/src/store/forwarder/authority.rs` (+3 -0) 📝 `crates/server/src/store/forwarder/mod.rs` (+1 -0) </details> ### 📄 Description I am trying to implement a wrapper around ForwardAuthority so I can intercept for rewriting/auditing what a dns forwarder produces. However implementing a wrapper is extremely challenging without ForwardLookup also being public. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>