[PR #2473] [MERGED] proto: change RecordSet::new() to take owned Name #3065

New issue

Closed

opened 2026-03-16 11:23:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:23:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2473
Author: @djc
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @djc

Base: main ← Head: rrset-name

📝 Commits (1)

f430d60 proto: change RecordSet::new() to take owned Name

📊 Changes

4 files changed (+20 additions, -15 deletions)

View changed files

📝 crates/proto/src/rr/rr_set.rs (+8 -8)
📝 crates/proto/src/serialize/txt/zone.rs (+3 -3)
📝 crates/server/src/store/in_memory/authority.rs (+7 -2)
📝 tests/integration-tests/tests/integration/truncation_tests.rs (+2 -2)

📄 Description

Since it stores a Name internally anyway, better to make this explicit towards the caller.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2473 **Author:** [@djc](https://github.com/djc) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `rrset-name` --- ### 📝 Commits (1) - [`f430d60`](https://github.com/hickory-dns/hickory-dns/commit/f430d60fc731191a3e67ed4381c1d7be16667d23) proto: change RecordSet::new() to take owned Name ### 📊 Changes **4 files changed** (+20 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/rr_set.rs` (+8 -8) 📝 `crates/proto/src/serialize/txt/zone.rs` (+3 -3) 📝 `crates/server/src/store/in_memory/authority.rs` (+7 -2) 📝 `tests/integration-tests/tests/integration/truncation_tests.rs` (+2 -2) </details> ### 📄 Description Since it stores a `Name` internally anyway, better to make this explicit towards the caller. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>