[PR #1629] [MERGED] fix truncation promotion to TCP #2473

New issue

Closed

opened 2026-03-16 08:55:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:55:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1629
Author: @bluejekyll
Created: 2/7/2022
Status: ✅ Merged
Merged: 2/8/2022
Merged by: @bluejekyll

Base: main ← Head: fix-tcp-promotion-on-truncation

📝 Commits (3)

71728c0 fix truncation promotion to TCP
654005c fix truncation test
b4448b6 add test for partial truncation response

📊 Changes

3 files changed (+59 additions, -8 deletions)

View changed files

📝 crates/proto/src/op/header.rs (+15 -0)
📝 crates/resolver/src/error.rs (+3 -5)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+41 -3)

📄 Description

fixes: #1627

I verified this with the example in #1627. Clearly we have a gap in testing, I want to track that down and add or fix the test case for this.

FYI, @peterthejohnston

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1629 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 2/7/2022 **Status:** ✅ Merged **Merged:** 2/8/2022 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix-tcp-promotion-on-truncation` --- ### 📝 Commits (3) - [`71728c0`](https://github.com/hickory-dns/hickory-dns/commit/71728c0609eab3fb4c07eb620cbdacd8d3ed1057) fix truncation promotion to TCP - [`654005c`](https://github.com/hickory-dns/hickory-dns/commit/654005c225d7b19efe360c0a5e7fae2e82e49ed0) fix truncation test - [`b4448b6`](https://github.com/hickory-dns/hickory-dns/commit/b4448b672749464b8851c96c7c11d88615f89501) add test for partial truncation response ### 📊 Changes **3 files changed** (+59 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/header.rs` (+15 -0) 📝 `crates/resolver/src/error.rs` (+3 -5) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+41 -3) </details> ### 📄 Description fixes: #1627 I verified this with the example in #1627. Clearly we have a gap in testing, I want to track that down and add or fix the test case for this. FYI, @peterthejohnston --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>