[PR #2434] [MERGED] CAA: Preserve reserved flags #3036

New issue

Closed

opened 2026-03-16 11:21:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:21:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2434
Author: @divergentdave
Created: 9/5/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @djc

Base: main ← Head: david/caa-preserve-flags

📝 Commits (1)

e6e4b84 CAA: Preserve reserved flags

📊 Changes

2 files changed (+67 additions, -28 deletions)

View changed files

📝 crates/proto/src/rr/rdata/caa.rs (+60 -20)
📝 crates/proto/src/serialize/txt/rdata_parsers/caa.rs (+7 -8)

📄 Description

This changes the CAA struct to hold the entire flags bitfield, instead of only preserving the Issuer Critical flag. This would prevent future compatibility problems if the reserved flags are ever used for something else.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2434 **Author:** [@divergentdave](https://github.com/divergentdave) **Created:** 9/5/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `david/caa-preserve-flags` --- ### 📝 Commits (1) - [`e6e4b84`](https://github.com/hickory-dns/hickory-dns/commit/e6e4b8406ebcf665d33012bec244fa0b4dc28806) CAA: Preserve reserved flags ### 📊 Changes **2 files changed** (+67 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/rr/rdata/caa.rs` (+60 -20) 📝 `crates/proto/src/serialize/txt/rdata_parsers/caa.rs` (+7 -8) </details> ### 📄 Description This changes the CAA struct to hold the entire flags bitfield, instead of only preserving the Issuer Critical flag. This would prevent future compatibility problems if the reserved flags are ever used for something else. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>