[PR #1577] [MERGED] Replace references to the 'with-backtrace' feature with 'backtrace' #2434

New issue

Closed

opened 2026-03-16 08:53:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:53:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1577
Author: @pinkisemils
Created: 10/27/2021
Status: ✅ Merged
Merged: 11/4/2021
Merged by: @bluejekyll

Base: main ← Head: fix-backtrace-feature

📝 Commits (2)

564b3c8 Allow constructing responses for lib users
c142226 Replace 'backtrace' with 'with-backtrace'

📊 Changes

4 files changed (+20 additions, -8 deletions)

View changed files

📝 crates/resolver/src/error.rs (+4 -4)
📝 crates/server/src/authority/message_response.rs (+14 -2)
📝 crates/server/src/error/config_error.rs (+1 -1)
📝 crates/server/src/error/persistence_error.rs (+1 -1)

📄 Description

It seems like some of the code is compiled only if with-backtrace feature is enabled, but I can't find any place where this feature would be declared. It seems to me that it's confused with the backtrace feature, and this confusion is producing some compiler warnings. As such, I've gone and replaced the references to with-backtrace with backtrace. Feel free to disregard these changes if there is some context that I'm missing as to why the feature is used in the code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1577 **Author:** [@pinkisemils](https://github.com/pinkisemils) **Created:** 10/27/2021 **Status:** ✅ Merged **Merged:** 11/4/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix-backtrace-feature` --- ### 📝 Commits (2) - [`564b3c8`](https://github.com/hickory-dns/hickory-dns/commit/564b3c89e12346ba41d11ece6d7b9506cf8f7ca1) Allow constructing responses for lib users - [`c142226`](https://github.com/hickory-dns/hickory-dns/commit/c142226a9b790e73b59f752df02135f00d84daa3) Replace 'backtrace' with 'with-backtrace' ### 📊 Changes **4 files changed** (+20 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/error.rs` (+4 -4) 📝 `crates/server/src/authority/message_response.rs` (+14 -2) 📝 `crates/server/src/error/config_error.rs` (+1 -1) 📝 `crates/server/src/error/persistence_error.rs` (+1 -1) </details> ### 📄 Description It seems like some of the code is compiled only if `with-backtrace` feature is enabled, but I can't find any place where this feature would be declared. It seems to me that it's confused with the `backtrace` feature, and this confusion is producing some compiler warnings. As such, I've gone and replaced the references to `with-backtrace` with `backtrace`. Feel free to disregard these changes if there is some context that I'm missing as to why the feature is used in the code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>