[PR #2393] [MERGED] only pass NSEC records to `verify_nsec` #3006

New issue

Closed

opened 2026-03-16 11:20:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:20:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2393
Author: @listochkin
Created: 8/29/2024
Status: ✅ Merged
Merged: 2/26/2025
Merged by: @djc

Base: main ← Head: al-verify-nsec-clearer-function-boundaries

📝 Commits (1)

0b6e833 proto: only pass NSEC records to verify_nsec

📊 Changes

2 files changed (+63 additions, -37 deletions)

View changed files

📝 bin/tests/integration/authority_battery/dnssec.rs (+45 -12)
📝 crates/proto/src/dnssec/dnssec_dns_handle/mod.rs (+18 -25)

📄 Description

Removes unnecessary filtering logic in the function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2393 **Author:** [@listochkin](https://github.com/listochkin) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 2/26/2025 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `al-verify-nsec-clearer-function-boundaries` --- ### 📝 Commits (1) - [`0b6e833`](https://github.com/hickory-dns/hickory-dns/commit/0b6e833c917aba91932b68521e604312e19e1e5e) proto: only pass NSEC records to `verify_nsec` ### 📊 Changes **2 files changed** (+63 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/integration/authority_battery/dnssec.rs` (+45 -12) 📝 `crates/proto/src/dnssec/dnssec_dns_handle/mod.rs` (+18 -25) </details> ### 📄 Description Removes unnecessary filtering logic in the function. Based on [similar feedback for NSEC3 validation](https://github.com/hickory-dns/hickory-dns/pull/2313#discussion_r1735715341) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>