[PR #1533] [MERGED] stop returning NS records on authoritative response #2393

New issue

Closed

opened 2026-03-16 08:51:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:51:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1533
Author: @bluejekyll
Created: 8/8/2021
Status: ✅ Merged
Merged: 8/22/2021
Merged by: @bluejekyll

Base: main ← Head: stop-returning-ns-on-auth-response

📝 Commits (5)

6ceeec8 stop returning NS records on authoritative response
dff6de7 ensure that request codes are properly set on responses
c37c913 return REFUSED instead of NXDOMAIN when no authorities found
a3521e9 tests for non-authoritative answers
5b316d7 add back named_forward_test

📊 Changes

9 files changed (+429 additions, -336 deletions)

View changed files

📝 Cargo.lock (+219 -263)
📝 bin/tests/named_tests.rs (+1 -0)
📝 crates/client/src/op/lower_query.rs (+1 -2)
📝 crates/proto/src/op/header.rs (+37 -0)
📝 crates/server/src/authority/catalog.rs (+59 -35)
📝 crates/server/src/authority/message_request.rs (+5 -0)
📝 crates/server/src/authority/message_response.rs (+3 -7)
📝 tests/integration-tests/tests/catalog_tests.rs (+103 -14)
📝 tests/integration-tests/tests/server_future_tests.rs (+1 -15)

📄 Description

This disables NS records from being included in the response on Authoritative responses.

Fixes: #1531

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1533 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 8/8/2021 **Status:** ✅ Merged **Merged:** 8/22/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `stop-returning-ns-on-auth-response` --- ### 📝 Commits (5) - [`6ceeec8`](https://github.com/hickory-dns/hickory-dns/commit/6ceeec8909194d89deee61dbebe693485fb7c865) stop returning NS records on authoritative response - [`dff6de7`](https://github.com/hickory-dns/hickory-dns/commit/dff6de790a70ce6d1d6f8cd6d46f08dc19899460) ensure that request codes are properly set on responses - [`c37c913`](https://github.com/hickory-dns/hickory-dns/commit/c37c9138932099617312967dc66cdb290bf94dce) return REFUSED instead of NXDOMAIN when no authorities found - [`a3521e9`](https://github.com/hickory-dns/hickory-dns/commit/a3521e9024c2cb52e800922363c87a48f5d7e9f7) tests for non-authoritative answers - [`5b316d7`](https://github.com/hickory-dns/hickory-dns/commit/5b316d7d69dbf89386d05f418c641944169231f4) add back named_forward_test ### 📊 Changes **9 files changed** (+429 additions, -336 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+219 -263) 📝 `bin/tests/named_tests.rs` (+1 -0) 📝 `crates/client/src/op/lower_query.rs` (+1 -2) 📝 `crates/proto/src/op/header.rs` (+37 -0) 📝 `crates/server/src/authority/catalog.rs` (+59 -35) 📝 `crates/server/src/authority/message_request.rs` (+5 -0) 📝 `crates/server/src/authority/message_response.rs` (+3 -7) 📝 `tests/integration-tests/tests/catalog_tests.rs` (+103 -14) 📝 `tests/integration-tests/tests/server_future_tests.rs` (+1 -15) </details> ### 📄 Description This disables NS records from being included in the response on Authoritative responses. Fixes: #1531 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>