[PR #2376] [MERGED] Revert "Fix stdout handling during hickory startup" #2998

New issue

Closed

opened 2026-03-16 11:19:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:19:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2376
Author: @japaric
Created: 8/23/2024
Status: ✅ Merged
Merged: 8/23/2024
Merged by: @japaric

Base: main ← Head: ja-revert-pr-2361

📝 Commits (1)

b7c229a Revert "Fix stdout handling during hickory startup"

📊 Changes

2 files changed (+6 additions, -16 deletions)

View changed files

📝 conformance/packages/dns-test/src/container.rs (+0 -7)
📝 conformance/packages/dns-test/src/resolver.rs (+6 -9)

📄 Description

This reverts commit 3344d2150d.

PR #2361 appears to have broken CI on main after being merged (1, 2) even though it passed CI when it was submitted as a PR (3)

I guess another this another vote for enabling the merge queue as previously suggested here https://github.com/hickory-dns/hickory-dns/pull/2281#issuecomment-2208981820 cc @bluejekyll

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2376 **Author:** [@japaric](https://github.com/japaric) **Created:** 8/23/2024 **Status:** ✅ Merged **Merged:** 8/23/2024 **Merged by:** [@japaric](https://github.com/japaric) **Base:** `main` ← **Head:** `ja-revert-pr-2361` --- ### 📝 Commits (1) - [`b7c229a`](https://github.com/hickory-dns/hickory-dns/commit/b7c229a3899a2bcee24c3209bb9876aa8c62923c) Revert "Fix stdout handling during hickory startup" ### 📊 Changes **2 files changed** (+6 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `conformance/packages/dns-test/src/container.rs` (+0 -7) 📝 `conformance/packages/dns-test/src/resolver.rs` (+6 -9) </details> ### 📄 Description This reverts commit 3344d2150dfd1cfe959c959fbfd1f7d457b8acf6. PR #2361 appears to have broken CI on `main` *after* being merged ([1](https://github.com/hickory-dns/hickory-dns/actions/runs/10523520502/job/29158365720), [2](https://github.com/hickory-dns/hickory-dns/actions/runs/10523528733/job/29158392769)) even though it passed CI when it was submitted as a PR ([3](https://github.com/hickory-dns/hickory-dns/actions/runs/10405968007/job/28851472972)) I guess another this another vote for enabling the merge queue as previously suggested here https://github.com/hickory-dns/hickory-dns/pull/2281#issuecomment-2208981820 cc @bluejekyll --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>