[PR #1506] [MERGED] Cleanup default features, remove dnssec from client and server default features #2376

New issue

Closed

opened 2026-03-16 08:50:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:50:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1506
Author: @bluejekyll
Created: 6/6/2021
Status: ✅ Merged
Merged: 6/30/2021
Merged by: @bluejekyll

Base: main ← Head: remove-default-dnssec-from-client

📝 Commits (7)

ddb02b0 move all DNSSECRecordType variants into RecordType
bffef62 move all DNSSECRecordType variants into RecordType
8fab877 introduce LookupOptions in Authority to allow dnssec feature off
998bf47 introduce DnssecAuthority to allow disabling of dnssec in authority
9c462bb remove default feature "dnssec" from client
d0b392e move dnssec switches on rrset into LookupOptions
410f45d Merge branch 'main' into remove-default-dnssec-from-client

📊 Changes

44 files changed (+847 additions, -1010 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 bin/benches/comparison_benches.rs (+3 -3)
📝 bin/src/named.rs (+94 -74)
📝 bin/tests/server_harness/mod.rs (+15 -19)
📝 bin/tests/server_harness/mut_message_client.rs (+10 -9)
📝 crates/client/Cargo.toml (+1 -3)
📝 crates/client/src/error/parse_error.rs (+9 -1)
📝 crates/client/src/rr/dnssec/mod.rs (+0 -2)
📝 crates/client/src/rr/dnssec/signer.rs (+2 -2)
📝 crates/client/src/rr/dnssec/tsig.rs (+2 -5)
📝 crates/client/src/rr/mod.rs (+4 -0)
📝 crates/client/src/serialize/txt/parse_rdata.rs (+12 -26)
📝 crates/proto/benches/lib.rs (+1 -1)
📝 crates/proto/src/op/message.rs (+6 -10)
📝 crates/proto/src/rr/dnssec/rdata/mod.rs (+24 -135)
📝 crates/proto/src/rr/dnssec/rdata/nsec.rs (+3 -5)
📝 crates/proto/src/rr/dnssec/rdata/nsec3.rs (+8 -8)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+4 -6)
📝 crates/proto/src/rr/record_data.rs (+9 -6)
📝 crates/proto/src/rr/record_type.rs (+78 -33)

...and 24 more files

📄 Description

This is a series of 5 commits to build up the the final commit to remove the default dnssec feature from the client crate.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1506 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 6/6/2021 **Status:** ✅ Merged **Merged:** 6/30/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `remove-default-dnssec-from-client` --- ### 📝 Commits (7) - [`ddb02b0`](https://github.com/hickory-dns/hickory-dns/commit/ddb02b0bf51e8ffdb652d0d08527bf050160351c) move all DNSSECRecordType variants into RecordType - [`bffef62`](https://github.com/hickory-dns/hickory-dns/commit/bffef6249cacdf7f748434282d347f775feb6faf) move all DNSSECRecordType variants into RecordType - [`8fab877`](https://github.com/hickory-dns/hickory-dns/commit/8fab87781f8fff6b5dcb98b0a1570da73db0b2fe) introduce LookupOptions in Authority to allow dnssec feature off - [`998bf47`](https://github.com/hickory-dns/hickory-dns/commit/998bf4791c0f38f7309ef217a447667bf85165fc) introduce DnssecAuthority to allow disabling of dnssec in authority - [`9c462bb`](https://github.com/hickory-dns/hickory-dns/commit/9c462bb54338782768640104cd55c57eca29878a) remove default feature "dnssec" from client - [`d0b392e`](https://github.com/hickory-dns/hickory-dns/commit/d0b392e33f6faadc2606a4d2b388d77a652d54d2) move dnssec switches on rrset into LookupOptions - [`410f45d`](https://github.com/hickory-dns/hickory-dns/commit/410f45d2b345932737e527cb1adbe8e712545684) Merge branch 'main' into remove-default-dnssec-from-client ### 📊 Changes **44 files changed** (+847 additions, -1010 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `bin/benches/comparison_benches.rs` (+3 -3) 📝 `bin/src/named.rs` (+94 -74) 📝 `bin/tests/server_harness/mod.rs` (+15 -19) 📝 `bin/tests/server_harness/mut_message_client.rs` (+10 -9) 📝 `crates/client/Cargo.toml` (+1 -3) 📝 `crates/client/src/error/parse_error.rs` (+9 -1) 📝 `crates/client/src/rr/dnssec/mod.rs` (+0 -2) 📝 `crates/client/src/rr/dnssec/signer.rs` (+2 -2) 📝 `crates/client/src/rr/dnssec/tsig.rs` (+2 -5) 📝 `crates/client/src/rr/mod.rs` (+4 -0) 📝 `crates/client/src/serialize/txt/parse_rdata.rs` (+12 -26) 📝 `crates/proto/benches/lib.rs` (+1 -1) 📝 `crates/proto/src/op/message.rs` (+6 -10) 📝 `crates/proto/src/rr/dnssec/rdata/mod.rs` (+24 -135) 📝 `crates/proto/src/rr/dnssec/rdata/nsec.rs` (+3 -5) 📝 `crates/proto/src/rr/dnssec/rdata/nsec3.rs` (+8 -8) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+4 -6) 📝 `crates/proto/src/rr/record_data.rs` (+9 -6) 📝 `crates/proto/src/rr/record_type.rs` (+78 -33) _...and 24 more files_ </details> ### 📄 Description This is a series of 5 commits to build up the the final commit to remove the default `dnssec` feature from the `client` crate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>