mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #778] including socket2 reuseport feature causes build failure on smartos/illumos #290
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#290
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rjloura on GitHub (May 21, 2019).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/778
Describe the bug
Currently smartos does not expose SO_REUSEPORT for native zones, so when trust-dns-resolver is included as a dependency
cargo buildfails with the following error:To Reproduce
Steps to reproduce the behavior:
Cargo buildExpected behavior
Expect trust-dns to build.
System:
Version:
Crate: [e.g. resolver]
Version: [e.g. 0.11.0]
Additional context
Workaround: Removing the
reuseportfeature from socket2 in trust-dns's proto dependencies "fixes" the issue. Although this is probably not the best long term fix. Perhaps thereuseportfeature should be conditional on linux or exclude illumos.github.com/rjloura/trust-dns@5cb9bb035d@bluejekyll commented on GitHub (May 21, 2019):
I think this is only needed for the mDNS feature. This feature should be defaulted to off as it’s got some unresolved issues.
Is this a build configuration issue?
@bluejekyll commented on GitHub (May 21, 2019):
Ok, yes. The proto crate should default the reuseport feature to off, and enable it when the mDNS feature is enabled. That should resolve this issue.
@bluejekyll commented on GitHub (May 21, 2019):
See #779 for what I think is the fix.