[PR #2187] [MERGED] fix(test): update ip of `example.com` #2869

New issue

Closed

opened 2026-03-16 11:12:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:12:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2187
Author: @situ2001
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/20/2024
Merged by: @bluejekyll

Base: main ← Head: fix/update-example-com-ip

📝 Commits (2)

e79072b fix: update ip of example.com
c955b57 fix: update ip of example.com

📊 Changes

32 files changed (+124 additions, -122 deletions)

View changed files

📝 README.md (+1 -1)
📝 bin/tests/named_tests.rs (+2 -2)
📝 crates/async-std-resolver/README.md (+2 -2)
📝 crates/async-std-resolver/src/lib.rs (+2 -2)
📝 crates/client/README.md (+1 -1)
📝 crates/client/src/client/async_client.rs (+2 -2)
📝 crates/client/src/lib.rs (+2 -2)
📝 crates/proto/src/h2/h2_client_stream.rs (+6 -6)
📝 crates/proto/src/h3/h3_client_stream.rs (+6 -6)
📝 crates/proto/src/op/message.rs (+1 -1)
📝 crates/proto/src/xfer/dns_multiplexer.rs (+6 -3)
📝 crates/resolver/README.md (+3 -3)
📝 crates/resolver/examples/custom_provider.rs (+2 -2)
📝 crates/resolver/src/async_resolver.rs (+15 -15)
📝 crates/resolver/src/h2.rs (+4 -4)
📝 crates/resolver/src/h3.rs (+4 -4)
📝 crates/resolver/src/lib.rs (+4 -4)
📝 crates/resolver/src/name_server/name_server_pool.rs (+2 -2)
📝 crates/resolver/src/quic.rs (+4 -4)
📝 crates/resolver/src/resolver.rs (+4 -4)

...and 12 more files

📄 Description

When running test of my app, I found that the test failed due to the IP of example.com being changed and also discovered that hickory dns has the same issue. So I proceeded to take the following steps to fix the test.

Change IPv4: from 93.184.216.34 to 93.184.215.14
Change IPv6: from 2606:2800:220:1:248:1893:25c8:1946 to 2606:2800:21f:cb07:6820:80da:af6b:8b2c

I searched for all occurrences and replaced them until cargo test is passed. And I'm unsure whether I need to do anything more for the tests that run locally. For example, github.com/hickory-dns/hickory-dns@76a4b84216/tests/integration-tests/tests/sqlite_authority_tests.rs (L55)

Reference: Here is another repo that fixed this issues 1d ago https://github.com/Chia-Network/chia-blockchain/pull/17894

I hope you can review it patiently, as there are many files involved in the changes. Thank you. Additionally, do we need to add a global variable or environment variable to handle future IP changes?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2187 **Author:** [@situ2001](https://github.com/situ2001) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/20/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fix/update-example-com-ip` --- ### 📝 Commits (2) - [`e79072b`](https://github.com/hickory-dns/hickory-dns/commit/e79072b0e308cbb1d2647a4dafe69d6d176c185c) fix: update ip of `example.com` - [`c955b57`](https://github.com/hickory-dns/hickory-dns/commit/c955b57d7546e7703dbd3e7dc707fe1518abfe59) fix: update ip of `example.com` ### 📊 Changes **32 files changed** (+124 additions, -122 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `bin/tests/named_tests.rs` (+2 -2) 📝 `crates/async-std-resolver/README.md` (+2 -2) 📝 `crates/async-std-resolver/src/lib.rs` (+2 -2) 📝 `crates/client/README.md` (+1 -1) 📝 `crates/client/src/client/async_client.rs` (+2 -2) 📝 `crates/client/src/lib.rs` (+2 -2) 📝 `crates/proto/src/h2/h2_client_stream.rs` (+6 -6) 📝 `crates/proto/src/h3/h3_client_stream.rs` (+6 -6) 📝 `crates/proto/src/op/message.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_multiplexer.rs` (+6 -3) 📝 `crates/resolver/README.md` (+3 -3) 📝 `crates/resolver/examples/custom_provider.rs` (+2 -2) 📝 `crates/resolver/src/async_resolver.rs` (+15 -15) 📝 `crates/resolver/src/h2.rs` (+4 -4) 📝 `crates/resolver/src/h3.rs` (+4 -4) 📝 `crates/resolver/src/lib.rs` (+4 -4) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+2 -2) 📝 `crates/resolver/src/quic.rs` (+4 -4) 📝 `crates/resolver/src/resolver.rs` (+4 -4) _...and 12 more files_ </details> ### 📄 Description When running test of my app, I found that the test failed due to the IP of `example.com` being changed and also discovered that hickory dns has the same issue. So I proceeded to take the following steps to fix the test. 1. Change IPv4: from `93.184.216.34` to `93.184.215.14` 2. Change IPv6: from `2606:2800:220:1:248:1893:25c8:1946` to `2606:2800:21f:cb07:6820:80da:af6b:8b2c` I searched for all occurrences and replaced them until `cargo test` is passed. And I'm unsure whether I need to do anything more for the tests that run locally. For example, https://github.com/hickory-dns/hickory-dns/blob/76a4b84216fa4984eafd4c4ceb5f0892ae3edbbf/tests/integration-tests/tests/sqlite_authority_tests.rs#L55 Reference: Here is another repo that fixed this issues 1d ago https://github.com/Chia-Network/chia-blockchain/pull/17894 I hope you can review it patiently, as there are many files involved in the changes. Thank you. Additionally, do we need to add a global variable or environment variable to handle future IP changes? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>