[PR #1301] [CLOSED] Replacing lru_cache with hashlink. #2187

New issue

Closed

opened 2026-03-16 07:06:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 07:06:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1301
Author: @sudarshan-reddy
Created: 11/24/2020
Status: ❌ Closed

Base: main ← Head: replace-lru_cache-hashlink

📝 Commits (1)

151fd76 Replacing lru_cache with hashlink.

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 crates/resolver/Cargo.toml (+1 -1)
📝 crates/resolver/src/dns_lru.rs (+1 -1)

📄 Description

What this PR does

Rust 1.48 introduces a check that causes a panic if the inner types have mem::uninitialized and aren't initialised. The version of linked-hash-map(v0.5.0) used by lru_cache would now panic if an insert is attempted. Moreover, lru_cache and linked-hash-map are not actively maintained.

This PR replaces lru_cache with hashlink which is a fork of linked-hash-map and therefore keeps the same API and is actively maintained.

References: https://github.com/rust-lang/rust/pull/71274/,
https://github.com/rusqlite/rusqlite/pull/811

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1301 **Author:** [@sudarshan-reddy](https://github.com/sudarshan-reddy) **Created:** 11/24/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `replace-lru_cache-hashlink` --- ### 📝 Commits (1) - [`151fd76`](https://github.com/hickory-dns/hickory-dns/commit/151fd7657a921b35526539e16419e586768d872a) Replacing lru_cache with hashlink. ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/Cargo.toml` (+1 -1) 📝 `crates/resolver/src/dns_lru.rs` (+1 -1) </details> ### 📄 Description ## What this PR does Rust 1.48 introduces a check that causes a panic if the inner types have mem::uninitialized and aren't initialised. The version of linked-hash-map(v0.5.0) used by lru_cache would now panic if an insert is attempted. Moreover, lru_cache and linked-hash-map are not actively maintained. This PR replaces lru_cache with hashlink which is a fork of linked-hash-map and therefore keeps the same API and is actively maintained. References: https://github.com/rust-lang/rust/pull/71274/, https://github.com/rusqlite/rusqlite/pull/811 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>