[PR #2123] [MERGED] Fixup lookup docs #2823

New issue

Closed

opened 2026-03-16 11:10:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:10:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2123
Author: @bluejekyll
Created: 1/1/2024
Status: ✅ Merged
Merged: 1/7/2024
Merged by: @bluejekyll

Base: main ← Head: fixup-lookup-docs

📝 Commits (2)

694c63a cleanup rust docs
86c1b6b clarify the iterators in the Lookup Types

📊 Changes

10 files changed (+29 additions, -22 deletions)

View changed files

📝 crates/async-std-resolver/src/lib.rs (+1 -1)
📝 crates/proto/src/error.rs (+1 -1)
📝 crates/proto/src/multicast/mdns_stream.rs (+2 -2)
📝 crates/proto/src/rr/rdata/caa.rs (+5 -5)
📝 crates/proto/src/rr/rdata/hinfo.rs (+6 -6)
📝 crates/proto/src/rr/rdata/opt.rs (+2 -0)
📝 crates/proto/src/xfer/mod.rs (+1 -1)
📝 crates/recursor/src/error.rs (+1 -1)
📝 crates/resolver/src/lookup.rs (+7 -4)
📝 crates/resolver/src/lookup_ip.rs (+3 -1)

📄 Description

After a discussion on discord, I noticed the Lookup docs needed to be clarified. Also took some time to cleanup some warnings around the rustdoc generation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2123 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 1/1/2024 **Status:** ✅ Merged **Merged:** 1/7/2024 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `fixup-lookup-docs` --- ### 📝 Commits (2) - [`694c63a`](https://github.com/hickory-dns/hickory-dns/commit/694c63a5df65a17a6a93b774c4c22915d0226e5e) cleanup rust docs - [`86c1b6b`](https://github.com/hickory-dns/hickory-dns/commit/86c1b6bfc121172f923081f85338c3554370c852) clarify the iterators in the Lookup Types ### 📊 Changes **10 files changed** (+29 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `crates/async-std-resolver/src/lib.rs` (+1 -1) 📝 `crates/proto/src/error.rs` (+1 -1) 📝 `crates/proto/src/multicast/mdns_stream.rs` (+2 -2) 📝 `crates/proto/src/rr/rdata/caa.rs` (+5 -5) 📝 `crates/proto/src/rr/rdata/hinfo.rs` (+6 -6) 📝 `crates/proto/src/rr/rdata/opt.rs` (+2 -0) 📝 `crates/proto/src/xfer/mod.rs` (+1 -1) 📝 `crates/recursor/src/error.rs` (+1 -1) 📝 `crates/resolver/src/lookup.rs` (+7 -4) 📝 `crates/resolver/src/lookup_ip.rs` (+3 -1) </details> ### 📄 Description After a discussion on discord, I noticed the Lookup docs needed to be clarified. Also took some time to cleanup some warnings around the rustdoc generation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>