[PR #1245] [MERGED] Cleanups to dependencies (split futures) and modernize style #2123

Closed
opened 2026-03-16 06:06:15 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1245
Author: @djc
Created: 10/12/2020
Status: Merged
Merged: 10/13/2020
Merged by: @bluejekyll

Base: mainHead: minimal-deps


📝 Commits (3)

  • 4c2b7da limit futures dependencies to what is necessary
  • 3f35075 adopt 2018 edition idioms
  • 4437f44 remove non-macro-use extern crate imports

📊 Changes

134 files changed (+315 additions, -556 deletions)

View changed files

📝 Cargo.lock (+13 -5)
📝 bin/benches/comparison_benches.rs (+0 -6)
📝 bin/src/named.rs (+0 -11)
📝 bin/tests/named_https_tests.rs (+0 -10)
📝 bin/tests/named_openssl_tests.rs (+0 -8)
📝 bin/tests/named_rustls_tests.rs (+0 -8)
📝 bin/tests/named_test_rsa_dnssec.rs (+0 -4)
📝 bin/tests/named_tests.rs (+0 -9)
📝 crates/async-std-resolver/Cargo.toml (+1 -1)
📝 crates/async-std-resolver/src/net.rs (+1 -1)
📝 crates/client/Cargo.toml (+2 -1)
📝 crates/client/src/client/async_client.rs (+7 -6)
📝 crates/client/src/client/async_secure_client.rs (+2 -1)
📝 crates/client/src/client/client.rs (+1 -1)
📝 crates/client/src/client/client_connection.rs (+1 -2)
📝 crates/client/src/client/memoize_client_handle.rs (+2 -2)
📝 crates/client/src/client/rc_future.rs (+3 -2)
📝 crates/client/src/error/client_error.rs (+1 -1)
📝 crates/https/Cargo.toml (+1 -1)
📝 crates/https/src/https_client_stream.rs (+4 -4)

...and 80 more files

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1245 **Author:** [@djc](https://github.com/djc) **Created:** 10/12/2020 **Status:** ✅ Merged **Merged:** 10/13/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `minimal-deps` --- ### 📝 Commits (3) - [`4c2b7da`](https://github.com/hickory-dns/hickory-dns/commit/4c2b7da6459fc63677036f395cd5a63610f63b40) limit futures dependencies to what is necessary - [`3f35075`](https://github.com/hickory-dns/hickory-dns/commit/3f35075e73b41a7c5d45f485a95dc832a7a01390) adopt 2018 edition idioms - [`4437f44`](https://github.com/hickory-dns/hickory-dns/commit/4437f443afebddd4533ba292ac623f33ec1606c9) remove non-macro-use extern crate imports ### 📊 Changes **134 files changed** (+315 additions, -556 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+13 -5) 📝 `bin/benches/comparison_benches.rs` (+0 -6) 📝 `bin/src/named.rs` (+0 -11) 📝 `bin/tests/named_https_tests.rs` (+0 -10) 📝 `bin/tests/named_openssl_tests.rs` (+0 -8) 📝 `bin/tests/named_rustls_tests.rs` (+0 -8) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+0 -4) 📝 `bin/tests/named_tests.rs` (+0 -9) 📝 `crates/async-std-resolver/Cargo.toml` (+1 -1) 📝 `crates/async-std-resolver/src/net.rs` (+1 -1) 📝 `crates/client/Cargo.toml` (+2 -1) 📝 `crates/client/src/client/async_client.rs` (+7 -6) 📝 `crates/client/src/client/async_secure_client.rs` (+2 -1) 📝 `crates/client/src/client/client.rs` (+1 -1) 📝 `crates/client/src/client/client_connection.rs` (+1 -2) 📝 `crates/client/src/client/memoize_client_handle.rs` (+2 -2) 📝 `crates/client/src/client/rc_future.rs` (+3 -2) 📝 `crates/client/src/error/client_error.rs` (+1 -1) 📝 `crates/https/Cargo.toml` (+1 -1) 📝 `crates/https/src/https_client_stream.rs` (+4 -4) _...and 80 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 06:06:15 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2123
No description provided.