[PR #2086] [CLOSED] Update h2_client_connection.rs #2804

New issue

Closed

opened 2026-03-16 11:09:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:09:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2086
Author: @marcbrevoort-cyberhive
Created: 10/31/2023
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (4)

b59753a Update h2_client_connection.rs
b0feea0 Merge branch 'main' into patch-1
5e22fe3 change the doc comment from inner to outer style
5b9d8ce webpki_roots must be "use"d in documentation

📊 Changes

1 file changed (+55 additions, -0 deletions)

View changed files

📝 crates/client/src/h2_client_connection.rs (+55 -0)

📄 Description

Documentation on using DNS over HTTPS
Was tested to work with these in Cargo.toml

[dependencies]
rustls = { version = "0.21.7" }
hickory-proto = { version = "0.24.0" }
hickory-client = { version = "0.24.0", default-features = false,features=["dns-over-https", "dns-over-https-rustls"]}
webpki-roots = { version = "0.23.1" }
tokio = { version = "1.27.0", features = ["full"] }

This should compile without errors or warnings, checked with cargo check and cargo clippy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2086 **Author:** [@marcbrevoort-cyberhive](https://github.com/marcbrevoort-cyberhive) **Created:** 10/31/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (4) - [`b59753a`](https://github.com/hickory-dns/hickory-dns/commit/b59753acc967a3d1bd49463b1ac47d851c1ec463) Update h2_client_connection.rs - [`b0feea0`](https://github.com/hickory-dns/hickory-dns/commit/b0feea0afb93a314e6c6cafd898999a6d856f6a0) Merge branch 'main' into patch-1 - [`5e22fe3`](https://github.com/hickory-dns/hickory-dns/commit/5e22fe322eec7cae3ad72a562269070b9dc6897f) change the doc comment from inner to outer style - [`5b9d8ce`](https://github.com/hickory-dns/hickory-dns/commit/5b9d8cea9174a5643554eb886e3ec332974ef9e4) webpki_roots must be "use"d in documentation ### 📊 Changes **1 file changed** (+55 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/h2_client_connection.rs` (+55 -0) </details> ### 📄 Description Documentation on using DNS over HTTPS Was tested to work with these in `Cargo.toml` ``` [dependencies] rustls = { version = "0.21.7" } hickory-proto = { version = "0.24.0" } hickory-client = { version = "0.24.0", default-features = false,features=["dns-over-https", "dns-over-https-rustls"]} webpki-roots = { version = "0.23.1" } tokio = { version = "1.27.0", features = ["full"] } ``` This should compile without errors or warnings, checked with `cargo check` and `cargo clippy`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>