[PR #1212] [MERGED] move NX trust bit from ResolverOpts to NameServerConfig #2086

New issue

Closed

opened 2026-03-16 05:42:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:42:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1212
Author: @djc
Created: 9/24/2020
Status: ✅ Merged
Merged: 9/26/2020
Merged by: @bluejekyll

Base: main ← Head: ns-trust

📝 Commits (2)

1b524af move NX trust bit from ResolverOpts to NameServerConfig
41e64ee clarify and update comment for NameServerConfig::trust_nx_responses

📊 Changes

9 files changed (+87 additions, -27 deletions)

View changed files

📝 CHANGELOG.md (+3 -2)
📝 crates/resolver/src/config.rs (+30 -10)
📝 crates/resolver/src/name_server/name_server.rs (+9 -2)
📝 crates/resolver/src/name_server/name_server_pool.rs (+5 -2)
📝 crates/resolver/src/system_conf/unix.rs (+4 -0)
📝 crates/resolver/src/system_conf/windows.rs (+2 -0)
📝 tests/integration-tests/tests/name_server_pool_tests.rs (+30 -9)
📝 tests/test-data/named_test_configs/example_forwarder.toml (+2 -2)
📝 util/src/resolve.rs (+2 -0)

📄 Description

As discussed.

As written, I do feel this is more "correct" but maybe also less ergonomic to use, since there's currently no easy way to modify the trust bit on an existing ResolverConfig. Maybe we should add a way to do that; some ideas that come to mind are a name_servers_mut() method on ResolverConfig or maybe even a dedicated fn trust_nx_responses(mut self)?

(I'm also fine if you just want to leave this out.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1212 **Author:** [@djc](https://github.com/djc) **Created:** 9/24/2020 **Status:** ✅ Merged **Merged:** 9/26/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `ns-trust` --- ### 📝 Commits (2) - [`1b524af`](https://github.com/hickory-dns/hickory-dns/commit/1b524afd86a7ba273d23efa393dc4e68c446d8e9) move NX trust bit from ResolverOpts to NameServerConfig - [`41e64ee`](https://github.com/hickory-dns/hickory-dns/commit/41e64ee2401a808bcfcd5439690d50b23438a472) clarify and update comment for NameServerConfig::trust_nx_responses ### 📊 Changes **9 files changed** (+87 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -2) 📝 `crates/resolver/src/config.rs` (+30 -10) 📝 `crates/resolver/src/name_server/name_server.rs` (+9 -2) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+5 -2) 📝 `crates/resolver/src/system_conf/unix.rs` (+4 -0) 📝 `crates/resolver/src/system_conf/windows.rs` (+2 -0) 📝 `tests/integration-tests/tests/name_server_pool_tests.rs` (+30 -9) 📝 `tests/test-data/named_test_configs/example_forwarder.toml` (+2 -2) 📝 `util/src/resolve.rs` (+2 -0) </details> ### 📄 Description As discussed. As written, I do feel this is more "correct" but maybe also less ergonomic to use, since there's currently no easy way to modify the trust bit on an existing `ResolverConfig`. Maybe we should add a way to do that; some ideas that come to mind are a `name_servers_mut()` method on `ResolverConfig` or maybe even a dedicated `fn trust_nx_responses(mut self)`? (I'm also fine if you just want to leave this out.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>