[PR #2059] [MERGED] Add root certificates to the binary crate #2786

New issue

Closed

opened 2026-03-16 11:08:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:08:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/2059
Author: @daxpedda
Created: 10/12/2023
Status: ✅ Merged
Merged: 10/13/2023
Merged by: @bluejekyll

Base: main ← Head: dns-roots

📝 Commits (1)

8a0260c Add root certificates to the binary crate

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 bin/Cargo.toml (+4 -1)

📄 Description

I'm not entirely sure I tested the same thing, but the following now works for me:

cargo run --bin dns -F dns-over-quic,resolver,recursor,native-certs -- -p quic -n 94.140.14.140:853 -t unfiltered.adguard-dns.com --debug query dns.google A

Interestingly, building with the webpki-roots feature, gives me an incredibly confusing error:

Package `trust-dns-integration v0.23.0 (/home/daxpedda/Documents/Projects/Game Experiment/trust-dns/tests/integration-tests)` does not have feature `webpki-roots`. It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.

Fixes #2000.
Cc @hingbong.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/2059 **Author:** [@daxpedda](https://github.com/daxpedda) **Created:** 10/12/2023 **Status:** ✅ Merged **Merged:** 10/13/2023 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `dns-roots` --- ### 📝 Commits (1) - [`8a0260c`](https://github.com/hickory-dns/hickory-dns/commit/8a0260ccaffd3dff3e656684c010b416708d87e7) Add root certificates to the binary crate ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `bin/Cargo.toml` (+4 -1) </details> ### 📄 Description I'm not entirely sure I tested the same thing, but the following now works for me: ``` cargo run --bin dns -F dns-over-quic,resolver,recursor,native-certs -- -p quic -n 94.140.14.140:853 -t unfiltered.adguard-dns.com --debug query dns.google A ``` Interestingly, building with the `webpki-roots` feature, gives me an incredibly confusing error: ``` Package `trust-dns-integration v0.23.0 (/home/daxpedda/Documents/Projects/Game Experiment/trust-dns/tests/integration-tests)` does not have feature `webpki-roots`. It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name. ``` Fixes #2000. Cc @hingbong. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>