[PR #1186] [MERGED] Support for lowercase DNSClass and RecordType fields in zonefiles #2059

New issue

Closed

opened 2026-03-16 05:18:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:18:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1186
Author: @zhanif3
Created: 8/10/2020
Status: ✅ Merged
Merged: 8/10/2020
Merged by: @bluejekyll

Base: main ← Head: uppercase_types

📝 Commits (3)

4dafef1 Added support for lowercase DNSClass and RecordType fields in zonefile entries, along with tests to validate behavior.
970c7ed Correcting rust fmt needs
099b0db Altered uppercase conversion per comments. We should no longer be allocating during conversion. Also added a debug_assert to ensure that we get what we expect.

📊 Changes

4 files changed (+38 additions, -2 deletions)

View changed files

📝 crates/client/src/serialize/txt/zone.rs (+2 -1)
📝 crates/proto/src/rr/dns_class.rs (+1 -0)
📝 crates/proto/src/rr/record_type.rs (+2 -1)
📝 crates/server/tests/txt_tests.rs (+33 -0)

📄 Description

Added support for lowercase DNSClass and RecordType fields in zonefile entries, along with tests to validate behavior. Doing this by converting the token to uppercase before matching. Added test to target this case specifically.

Feature requested to parse TLD zonefiles published by ICANN as a part of their CZDS service.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1186 **Author:** [@zhanif3](https://github.com/zhanif3) **Created:** 8/10/2020 **Status:** ✅ Merged **Merged:** 8/10/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `uppercase_types` --- ### 📝 Commits (3) - [`4dafef1`](https://github.com/hickory-dns/hickory-dns/commit/4dafef1d1bf02bf23e2798c9426cdc83d0b2ed91) Added support for lowercase DNSClass and RecordType fields in zonefile entries, along with tests to validate behavior. - [`970c7ed`](https://github.com/hickory-dns/hickory-dns/commit/970c7ed4a6c6adf2d76c53756d76d43ee47c0f37) Correcting rust fmt needs - [`099b0db`](https://github.com/hickory-dns/hickory-dns/commit/099b0db6c77f7f0f581dc6d99f930698d397be1c) Altered uppercase conversion per comments. We should no longer be allocating during conversion. Also added a debug_assert to ensure that we get what we expect. ### 📊 Changes **4 files changed** (+38 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/zone.rs` (+2 -1) 📝 `crates/proto/src/rr/dns_class.rs` (+1 -0) 📝 `crates/proto/src/rr/record_type.rs` (+2 -1) 📝 `crates/server/tests/txt_tests.rs` (+33 -0) </details> ### 📄 Description Added support for lowercase DNSClass and RecordType fields in zonefile entries, along with tests to validate behavior. Doing this by converting the token to uppercase before matching. Added test to target this case specifically. Feature requested to parse TLD zonefiles published by ICANN as a part of their CZDS service. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>