[PR #1948] [MERGED] fix: remove duplicate is_soa function #2712

New issue

Closed

opened 2026-03-16 11:04:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 11:04:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1948
Author: @mattsse
Created: 5/28/2023
Status: ✅ Merged
Merged: 5/31/2023
Merged by: @djc

Base: main ← Head: matt/bump-enum-as-inner

📝 Commits (2)

b409852 fix: remove duplicate is_soa function
a0cc556 chore: upgrade enum-as-inner 0.6

📊 Changes

3 files changed (+4 additions, -9 deletions)

View changed files

📝 Cargo.lock (+3 -3)
📝 Cargo.toml (+1 -1)
📝 crates/proto/src/rr/record_data.rs (+0 -5)

📄 Description

enum-as-inner now generates is_* functions itself:

github.com/bluejekyll/enum-as-inner@514cfbf2af/src/lib.rs (L173-L175)

Closes #1946

Changes

cargo update -p enum-as-inner -> 0.5.2
remove is_soa

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1948 **Author:** [@mattsse](https://github.com/mattsse) **Created:** 5/28/2023 **Status:** ✅ Merged **Merged:** 5/31/2023 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `matt/bump-enum-as-inner` --- ### 📝 Commits (2) - [`b409852`](https://github.com/hickory-dns/hickory-dns/commit/b40985276cfc60686c05d448b953e9b3549dd08a) fix: remove duplicate is_soa function - [`a0cc556`](https://github.com/hickory-dns/hickory-dns/commit/a0cc55619f78053d47601f658037f2edd36f9924) chore: upgrade enum-as-inner 0.6 ### 📊 Changes **3 files changed** (+4 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+3 -3) 📝 `Cargo.toml` (+1 -1) 📝 `crates/proto/src/rr/record_data.rs` (+0 -5) </details> ### 📄 Description enum-as-inner now generates `is_*` functions itself: https://github.com/bluejekyll/enum-as-inner/blob/514cfbf2af2d981ce9a4a2e1b680412705721ca6/src/lib.rs#L173-L175 Closes #1946 ## Changes * cargo update -p enum-as-inner -> 0.5.2 * remove `is_soa` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>