[PR #1077] [MERGED] use RuntimeProvider in https #1948

New issue

Closed

opened 2026-03-16 04:00:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 04:00:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1077
Author: @balboah
Created: 4/21/2020
Status: ✅ Merged
Merged: 5/2/2020
Merged by: @bluejekyll

Base: master ← Head: feature/custom_bind

📝 Commits (8)

7b0e66c logger: missing https crate
24939f0 AsyncResolver: remove async from new()
276b854 RuntimeProvider::Tcp: remove async read/write
bda24bd https: use RuntimeProvider when making connections
bf1f283 cleanup tests
486a065 rebase master for 0.19.5
c312270 fix windows tests
1bd9ff1 Merge branch 'master' into feature/custom_bind

📊 Changes

20 files changed (+190 additions, -129 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 bin/Cargo.toml (+1 -0)
📝 bin/tests/named_https_tests.rs (+5 -2)
📝 crates/async-std-resolver/src/lib.rs (+2 -2)
📝 crates/async-std-resolver/src/tests.rs (+1 -1)
📝 crates/client/src/https_client_connection.rs (+12 -5)
📝 crates/https/src/https_client_stream.rs (+42 -17)
📝 crates/proto/src/lib.rs (+32 -0)
📝 crates/resolver/examples/global_resolver.rs (+1 -1)
📝 crates/resolver/examples/multithreaded_runtime.rs (+2 -7)
📝 crates/resolver/src/async_resolver.rs (+49 -54)
📝 crates/resolver/src/dns_sd.rs (+2 -4)
📝 crates/resolver/src/https.rs (+9 -7)
📝 crates/resolver/src/lib.rs (+5 -7)
📝 crates/resolver/src/name_server/connection_provider.rs (+17 -10)
📝 crates/resolver/src/resolver.rs (+2 -4)
📝 crates/resolver/src/tls/mod.rs (+2 -4)
📝 crates/server/src/logger.rs (+1 -1)
📝 crates/server/src/store/forwarder/authority.rs (+0 -2)
📝 tests/integration-tests/tests/client_future_tests.rs (+4 -1)

📄 Description

This is an early PR as a first step for closing #1074

use RuntimeProvider when making TCP connections
use RuntimeProvider when making TLS upgrades
migrate tests
remove async for AsyncResolver::new()

I'll fix the test migration after review but will probably not do the TLS part in this PR.

Sorry for the scope creep in #1056, but I feel it's related to this.

Fixes: #1056
Fixes: #1074

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1077 **Author:** [@balboah](https://github.com/balboah) **Created:** 4/21/2020 **Status:** ✅ Merged **Merged:** 5/2/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `feature/custom_bind` --- ### 📝 Commits (8) - [`7b0e66c`](https://github.com/hickory-dns/hickory-dns/commit/7b0e66cf2b26d22fc5e8bbb9b52caced72733a9f) logger: missing https crate - [`24939f0`](https://github.com/hickory-dns/hickory-dns/commit/24939f0cf7493a686f5c00f83b0acf1b050bdd6a) AsyncResolver: remove async from new() - [`276b854`](https://github.com/hickory-dns/hickory-dns/commit/276b8549479b43c7400050d057e87637adc7342b) RuntimeProvider::Tcp: remove async read/write - [`bda24bd`](https://github.com/hickory-dns/hickory-dns/commit/bda24bdef061714d6be64fbbcf0800f389ec0020) https: use RuntimeProvider when making connections - [`bf1f283`](https://github.com/hickory-dns/hickory-dns/commit/bf1f283d82716eacf0cce9d8a44d7d4412e32a53) cleanup tests - [`486a065`](https://github.com/hickory-dns/hickory-dns/commit/486a065466489303036d295a756403907a2c2b37) rebase master for 0.19.5 - [`c312270`](https://github.com/hickory-dns/hickory-dns/commit/c312270b0afa7af63f4386ec85edd3ef0bf8fa2f) fix windows tests - [`1bd9ff1`](https://github.com/hickory-dns/hickory-dns/commit/1bd9ff16e510a2d5284bc71ad151c8c4349b0d13) Merge branch 'master' into feature/custom_bind ### 📊 Changes **20 files changed** (+190 additions, -129 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `bin/Cargo.toml` (+1 -0) 📝 `bin/tests/named_https_tests.rs` (+5 -2) 📝 `crates/async-std-resolver/src/lib.rs` (+2 -2) 📝 `crates/async-std-resolver/src/tests.rs` (+1 -1) 📝 `crates/client/src/https_client_connection.rs` (+12 -5) 📝 `crates/https/src/https_client_stream.rs` (+42 -17) 📝 `crates/proto/src/lib.rs` (+32 -0) 📝 `crates/resolver/examples/global_resolver.rs` (+1 -1) 📝 `crates/resolver/examples/multithreaded_runtime.rs` (+2 -7) 📝 `crates/resolver/src/async_resolver.rs` (+49 -54) 📝 `crates/resolver/src/dns_sd.rs` (+2 -4) 📝 `crates/resolver/src/https.rs` (+9 -7) 📝 `crates/resolver/src/lib.rs` (+5 -7) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+17 -10) 📝 `crates/resolver/src/resolver.rs` (+2 -4) 📝 `crates/resolver/src/tls/mod.rs` (+2 -4) 📝 `crates/server/src/logger.rs` (+1 -1) 📝 `crates/server/src/store/forwarder/authority.rs` (+0 -2) 📝 `tests/integration-tests/tests/client_future_tests.rs` (+4 -1) </details> ### 📄 Description This is an early PR as a first step for closing #1074 - [X] use RuntimeProvider when making TCP connections - [ ] use RuntimeProvider when making TLS upgrades - [x] migrate tests - [X] remove `async` for AsyncResolver::new() I'll fix the test migration after review but will probably not do the TLS part in this PR. Sorry for the scope creep in #1056, but I feel it's related to this. ---- Fixes: #1056 Fixes: #1074 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>