starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00

[GH-ISSUE #658] Make tokio optional dependeny for resolver #268

New issue

Closed

opened 2026-03-07 23:08:57 +03:00 by kerem · 9 comments

kerem commented

2026-03-07 23:08:57 +03:00

Owner

Originally created by @fafhrd91 on GitHub (Jan 13, 2019).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/658

Originally created by @fafhrd91 on GitHub (Jan 13, 2019). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/658

kerem

2026-03-07 23:08:57 +03:00

closed this issue
added the
crate:resolver
label

kerem commented

2026-03-07 23:09:13 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jan 14, 2019):

We can make tokio optional, it looks like this will require us to disable the synchronous Resolver, but the AsyncResolver should be fine. It needs to be a dev dependency for tests. I'm assuming this will be ok?

It will default to on, and will require default-features=false on the Cargo.toml dependency line. Sound good?

@bluejekyll commented on GitHub (Jan 14, 2019): We can make `tokio` optional, it looks like this will require us to disable the synchronous `Resolver`, but the `AsyncResolver` should be fine. It needs to be a dev dependency for tests. I'm assuming this will be ok? It will default to on, and will require `default-features=false` on the Cargo.toml dependency line. Sound good?

kerem commented

2026-03-07 23:09:18 +03:00

Author

Owner

@fafhrd91 commented on GitHub (Jan 14, 2019):

Default is on is totally fine. Thanks!

@fafhrd91 commented on GitHub (Jan 14, 2019): Default is on is totally fine. Thanks!

kerem commented

2026-03-07 23:09:23 +03:00

Author

Owner

@fafhrd91 commented on GitHub (Jan 14, 2019):

when do you plan to release this feature?

@fafhrd91 commented on GitHub (Jan 14, 2019): when do you plan to release this feature?

kerem commented

2026-03-07 23:09:28 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jan 14, 2019):

I'm planning on releasing 0.11.0-alpha soon. I'm just polishing up some things in another PR that I'd like to land before doing that.

Is this a blocker? I could backport to 0.10 if this is urgent.

@bluejekyll commented on GitHub (Jan 14, 2019): I'm planning on releasing 0.11.0-alpha soon. I'm just polishing up some things in another PR that I'd like to land before doing that. Is this a blocker? I could backport to 0.10 if this is urgent.

kerem commented

2026-03-07 23:09:33 +03:00

Author

Owner

@fafhrd91 commented on GitHub (Jan 14, 2019):

It is fine. I just need to know timeframe.

@fafhrd91 commented on GitHub (Jan 14, 2019): It is fine. I just need to know timeframe.

kerem commented

2026-03-07 23:09:39 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jan 14, 2019):

I can't promise a timeline, but I was hoping to start the next alpha release series in the next week.

@bluejekyll commented on GitHub (Jan 14, 2019): I can't promise a timeline, but I was hoping to start the next alpha release series in the next week.

kerem commented

2026-03-07 23:09:44 +03:00

Author

Owner

@fafhrd91 commented on GitHub (Mar 25, 2019):

@bluejekyll when do you plan to release 0.11?

@fafhrd91 commented on GitHub (Mar 25, 2019): @bluejekyll when do you plan to release 0.11?

kerem commented

2026-03-07 23:09:49 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 25, 2019):

I think you mean non-alpha? I would like to publish one more alpha, let that bake a little, and then release 0.11. The next alpha would be in the next week, and that should be the last one, assuming no serious complaints. So maybe 4 weeks?

@bluejekyll commented on GitHub (Mar 25, 2019): I think you mean non-alpha? I would like to publish one more alpha, let that bake a little, and then release 0.11. The next alpha would be in the next week, and that should be the last one, assuming no serious complaints. So maybe 4 weeks?

kerem commented

2026-03-07 23:09:54 +03:00

Author

Owner

@fafhrd91 commented on GitHub (Mar 25, 2019):

ok, thanks.

@fafhrd91 commented on GitHub (Mar 25, 2019): ok, thanks.

kerem referenced this issue

2026-03-16 02:00:31 +03:00

[PR #268] [MERGED] Don't enable DNSSEC by default in -resolver. #1326

kerem referenced this issue

2026-03-16 02:00:31 +03:00