[PR #269] [CLOSED] Don't enable the ipconfig feature by default #1328

New issue

Closed

opened 2026-03-16 02:00:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:00:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/269
Author: @briansmith
Created: 10/26/2017
Status: ❌ Closed

Base: master ← Head: no-ipconfig-default-resolver

📝 Commits (4)

af6bfc4 Don't enable DNSSEC by default in -resolver.
e0a20e0 Don't enable ipconfig by default until it is easier to build.
5084a67 Merge branch 'master' into no-ipconfig-default-resolver
6e7333a Merge branch 'master' into no-ipconfig-default-resolver

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 resolver/Cargo.toml (+0 -1)

📄 Description

[This is a Windows-specific change. This PR was factored out of #268 and is designed to be merged on top of #268.]

Right now ipconfig doesn't build without extra work in at least some
situations. For example, it doesn't build on my system because it can't
find clang.dll. This is at odds with my goal of making Trust-DNS build
out-of-the box in the default configuration on all typical platforms as
easily as any other Rust codebase, which is required in order to help
others adopt it.

I filed an issue upstream explaining the problem and suggesting a fix
(liranringel/ipconfig#3). The maintainer said
my suggested solution is good, so it is possible that the build
situation will get better soon.

At least until then, make ipconfig a non-default feature.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/269 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 10/26/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `no-ipconfig-default-resolver` --- ### 📝 Commits (4) - [`af6bfc4`](https://github.com/hickory-dns/hickory-dns/commit/af6bfc40550f8dc7571e4bd7cfb8d32261889c57) Don't enable DNSSEC by default in -resolver. - [`e0a20e0`](https://github.com/hickory-dns/hickory-dns/commit/e0a20e0fab7554e8771be3d8c65a7b8007dee4bc) Don't enable ipconfig by default until it is easier to build. - [`5084a67`](https://github.com/hickory-dns/hickory-dns/commit/5084a67f7d76aaad4706f9f0436f2dd15bb074e3) Merge branch 'master' into no-ipconfig-default-resolver - [`6e7333a`](https://github.com/hickory-dns/hickory-dns/commit/6e7333ab1bd883543185d6ac407a929869b7272b) Merge branch 'master' into no-ipconfig-default-resolver ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `resolver/Cargo.toml` (+0 -1) </details> ### 📄 Description [This is a Windows-specific change. This PR was factored out of #268 and is designed to be merged on top of #268.] Right now ipconfig doesn't build without extra work in at least some situations. For example, it doesn't build on my system because it can't find clang.dll. This is at odds with my goal of making Trust-DNS build out-of-the box in the default configuration on all typical platforms as easily as any other Rust codebase, which is required in order to help others adopt it. I filed an issue upstream explaining the problem and suggesting a fix (liranringel/ipconfig#3). The maintainer said my suggested solution is good, so it is possible that the build situation will get better soon. At least until then, make ipconfig a non-default feature. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>