[GH-ISSUE #650] syncrhonous Resolver should maintain conn pool across uses #262

New issue

Closed

opened 2026-03-07 23:06:36 +03:00 by kerem · 4 comments

kerem commented

2026-03-07 23:06:36 +03:00

Owner

Originally created by @bluejekyll on GitHub (Jan 7, 2019).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/650

Is your feature request related to a problem? Please describe.

See comment: https://github.com/bluejekyll/trust-dns/issues/532#issuecomment-451251197 where the usage of the synchronous Resolver is expected to maintain connections across uses.

Describe the solution you'd like

The Global Resolver described in #462 is most-likely the best option. An issue to determine is how to make that programatically configurable.

Describe alternatives you've considered

Another option would be to rely on tokio's background processing, but this needs to be researching.

Additional context

The synchronous Resolver does not hold a reference to a Tokio runtime, to ensure that it itself is Send/Sync, see documentation here: https://docs.rs/trust-dns-resolver/0.10.2/trust_dns_resolver/struct.Resolver.html

Originally created by @bluejekyll on GitHub (Jan 7, 2019). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/650 **Is your feature request related to a problem? Please describe.** See comment: https://github.com/bluejekyll/trust-dns/issues/532#issuecomment-451251197 where the usage of the synchronous Resolver is expected to maintain connections across uses. **Describe the solution you'd like** The Global Resolver described in #462 is most-likely the best option. An issue to determine is how to make that programatically configurable. **Describe alternatives you've considered** Another option would be to rely on tokio's background processing, but this needs to be researching. **Additional context** The synchronous Resolver does not hold a reference to a Tokio runtime, to ensure that it itself is Send/Sync, see documentation here: https://docs.rs/trust-dns-resolver/0.10.2/trust_dns_resolver/struct.Resolver.html

kerem

2026-03-07 23:06:36 +03:00

closed this issue
added the
enhance

perf

crate:resolver
labels

kerem commented

2026-03-07 23:06:53 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jan 7, 2019):

FYI @juliangehring

@bluejekyll commented on GitHub (Jan 7, 2019): FYI @juliangehring

kerem commented

2026-03-07 23:06:58 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jan 7, 2019):

Hm, When the decision was made to not carry the old Tokio::Core it appeared that there was no way to have a Send+Sync syncronous Resolver. This appears to have changed. As tokio::Runtime now appears to be Send+Sync. This means it's possible for the Resolver to have a Runtime.

This is probably the easiest patch for the issue.

@bluejekyll commented on GitHub (Jan 7, 2019): Hm, When the decision was made to not carry the old `Tokio::Core` it appeared that there was no way to have a `Send+Sync` syncronous Resolver. This appears to have changed. As tokio::Runtime now appears to be `Send+Sync`. This means it's possible for the Resolver to have a Runtime. This is probably the easiest patch for the issue.

kerem commented

2026-03-07 23:07:04 +03:00

Author

Owner

@juliangehring commented on GitHub (Jan 13, 2019):

Thanks, it works very well now!

@juliangehring commented on GitHub (Jan 13, 2019): Thanks, it works very well now!

kerem commented

2026-03-07 23:07:09 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jan 13, 2019):

Thank you for the feedback. It does have a downside of locking between threads on queries, if you share the instance across threads. Just making sure you’re aware of that downside.

@bluejekyll commented on GitHub (Jan 13, 2019): Thank you for the feedback. It does have a downside of locking between threads on queries, if you share the instance across threads. Just making sure you’re aware of that downside.

kerem referenced this issue

2026-03-16 02:00:31 +03:00

[PR #262] [MERGED] Remove deprecated APIs from -proto. #1329