[PR #262] [MERGED] Remove deprecated APIs from -proto. #1329

New issue

Closed

opened 2026-03-16 02:00:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:00:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/262
Author: @briansmith
Created: 10/25/2017
Status: ✅ Merged
Merged: 10/25/2017
Merged by: @bluejekyll

Base: master ← Head: remove-deprecated

📝 Commits (7)

f2f8fe6 Remove deprecated Domain functions.
6f0aeb6 Remove unused import in -proto's domain.rs tests.
a2520b6 Remove deprecated Record::add_name().
022ac3b Remove functions that will be "removed post 0.9.x".
3d97828 Remove "kinda broken" impl<'a> From<&'a RData> for RecordType.
daaafe3 Merge branch 'master' into remove-deprecated
963b09b Merge branch 'master' into remove-deprecated

📊 Changes

5 files changed (+25 additions, -147 deletions)

View changed files

📝 proto/src/op/message.rs (+0 -32)
📝 proto/src/rr/domain.rs (+0 -74)
📝 proto/src/rr/mod.rs (+0 -4)
📝 proto/src/rr/record_data.rs (+25 -29)
📝 proto/src/rr/resource.rs (+0 -8)

📄 Description

I read the API deprecation policy and IIUC this is all in line with the deprecation policy. This will help with the auditing of the code so I'd like to do it sooner than later if it is at all reasonable to do so.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/262 **Author:** [@briansmith](https://github.com/briansmith) **Created:** 10/25/2017 **Status:** ✅ Merged **Merged:** 10/25/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `remove-deprecated` --- ### 📝 Commits (7) - [`f2f8fe6`](https://github.com/hickory-dns/hickory-dns/commit/f2f8fe63aa6a2fd7c18b92201bef0435c5b1b093) Remove deprecated `Domain` functions. - [`6f0aeb6`](https://github.com/hickory-dns/hickory-dns/commit/6f0aeb6472d192d469d6ca78c484fdb8956205e7) Remove unused import in -proto's domain.rs tests. - [`a2520b6`](https://github.com/hickory-dns/hickory-dns/commit/a2520b669ca89bbe184c10486ea4f5399bafba3c) Remove deprecated Record::add_name(). - [`022ac3b`](https://github.com/hickory-dns/hickory-dns/commit/022ac3b5b9a891c4f180e3cd61f57ac7cb6e1e52) Remove functions that will be "removed post 0.9.x". - [`3d97828`](https://github.com/hickory-dns/hickory-dns/commit/3d978285743f08a6b996ec82ab3c09572f43276e) Remove "kinda broken" impl<'a> From<&'a RData> for RecordType. - [`daaafe3`](https://github.com/hickory-dns/hickory-dns/commit/daaafe3a0428a06cf240ed75d906891c47e05b4c) Merge branch 'master' into remove-deprecated - [`963b09b`](https://github.com/hickory-dns/hickory-dns/commit/963b09b73295feefb6cd505fbf03c59025f191a1) Merge branch 'master' into remove-deprecated ### 📊 Changes **5 files changed** (+25 additions, -147 deletions) <details> <summary>View changed files</summary> 📝 `proto/src/op/message.rs` (+0 -32) 📝 `proto/src/rr/domain.rs` (+0 -74) 📝 `proto/src/rr/mod.rs` (+0 -4) 📝 `proto/src/rr/record_data.rs` (+25 -29) 📝 `proto/src/rr/resource.rs` (+0 -8) </details> ### 📄 Description I read the API deprecation policy and IIUC this is all in line with the deprecation policy. This will help with the auditing of the code so I'd like to do it sooner than later if it is at all reasonable to do so. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>