[PR #1626] [MERGED] Make message round trip for fuzzing #2469

New issue

Closed

opened 2026-03-16 08:55:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:55:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1626
Author: @bluejekyll
Created: 2/5/2022
Status: ✅ Merged
Merged: 2/7/2022
Merged by: @djc

Base: main ← Head: make-message-round-trip-for-fuzzing

📝 Commits (10+)

2324d04 Add a Message fuzzing target
3412242 moved fuzz to a top-level-directory
f001373 Add failing test from round-trip fuzzing
9aef9a5 Fix failing test
250db06 Make Record's Default impl consistent
addee27 Do not use NULL rdata with ZERO rtype
7cb405d first pass, make RData optional in Record
1df52be add assert that all data in rd_length is consumed
022a679 ensure ZERO RData length is always verified
82aaf89 remove deprecated uses of Record::rdata

📊 Changes

62 files changed (+1344 additions, -534 deletions)

View changed files

📝 .gitignore (+4 -0)
📝 Cargo.lock (+2 -2)
📝 Cargo.toml (+2 -0)
📝 Makefile.toml (+1 -0)
📝 bin/benches/comparison_benches.rs (+1 -1)
📝 bin/tests/named_tests.rs (+2 -2)
📝 bin/tests/server_harness/mod.rs (+3 -3)
📝 crates/client/README.md (+1 -1)
📝 crates/client/src/client/async_client.rs (+2 -7)
📝 crates/client/src/lib.rs (+3 -3)
📝 crates/client/src/op/update_message.rs (+1 -1)
📝 crates/client/src/rr/dnssec/signer.rs (+34 -16)
📝 crates/client/src/rr/dnssec/tsig.rs (+1 -1)
📝 crates/client/src/serialize/txt/parse_rdata.rs (+1 -0)
📝 crates/client/src/serialize/txt/rdata_parsers/svcb.rs (+4 -2)
📝 crates/client/src/serialize/txt/zone.rs (+2 -2)
📝 crates/proto/src/https/https_client_stream.rs (+16 -20)
📝 crates/proto/src/op/edns.rs (+6 -5)
📝 crates/proto/src/op/message.rs (+9 -0)
📝 crates/proto/src/rr/dnssec/rdata/tsig.rs (+3 -3)

...and 42 more files

📄 Description

@saethlin, I'm finally picking this back up. I restructured the directories in your fuzz layout, but otherwise this directly copies your work in #1606

closes: #1606
closes: #1605
Fixes: #1571
Fixes: #1570

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1626 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 2/5/2022 **Status:** ✅ Merged **Merged:** 2/7/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `make-message-round-trip-for-fuzzing` --- ### 📝 Commits (10+) - [`2324d04`](https://github.com/hickory-dns/hickory-dns/commit/2324d041cc97a08753a1bf9ca9e127e6a606fd82) Add a Message fuzzing target - [`3412242`](https://github.com/hickory-dns/hickory-dns/commit/3412242ce4b3ce461f39e2a79307866033a35169) moved fuzz to a top-level-directory - [`f001373`](https://github.com/hickory-dns/hickory-dns/commit/f00137382f04de9f193068637c580e651b6f7ee9) Add failing test from round-trip fuzzing - [`9aef9a5`](https://github.com/hickory-dns/hickory-dns/commit/9aef9a5e43899e5842aa450db1688a2371908b59) Fix failing test - [`250db06`](https://github.com/hickory-dns/hickory-dns/commit/250db069e132ba04694e01e812591c95952cb35d) Make Record's Default impl consistent - [`addee27`](https://github.com/hickory-dns/hickory-dns/commit/addee279fc0bbf464366c375c5c76df37611ad6b) Do not use NULL rdata with ZERO rtype - [`7cb405d`](https://github.com/hickory-dns/hickory-dns/commit/7cb405db2d0455609f606d3beb5d25e067e396ee) first pass, make RData optional in Record - [`1df52be`](https://github.com/hickory-dns/hickory-dns/commit/1df52be8a4add7dbe16dafd881872b28e259ca7b) add assert that all data in rd_length is consumed - [`022a679`](https://github.com/hickory-dns/hickory-dns/commit/022a67955db0db1999414b05dfd601ee28526e77) ensure ZERO RData length is always verified - [`82aaf89`](https://github.com/hickory-dns/hickory-dns/commit/82aaf89f7c7e98a833dee48183fce76f206c7efb) remove deprecated uses of Record::rdata ### 📊 Changes **62 files changed** (+1344 additions, -534 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+4 -0) 📝 `Cargo.lock` (+2 -2) 📝 `Cargo.toml` (+2 -0) 📝 `Makefile.toml` (+1 -0) 📝 `bin/benches/comparison_benches.rs` (+1 -1) 📝 `bin/tests/named_tests.rs` (+2 -2) 📝 `bin/tests/server_harness/mod.rs` (+3 -3) 📝 `crates/client/README.md` (+1 -1) 📝 `crates/client/src/client/async_client.rs` (+2 -7) 📝 `crates/client/src/lib.rs` (+3 -3) 📝 `crates/client/src/op/update_message.rs` (+1 -1) 📝 `crates/client/src/rr/dnssec/signer.rs` (+34 -16) 📝 `crates/client/src/rr/dnssec/tsig.rs` (+1 -1) 📝 `crates/client/src/serialize/txt/parse_rdata.rs` (+1 -0) 📝 `crates/client/src/serialize/txt/rdata_parsers/svcb.rs` (+4 -2) 📝 `crates/client/src/serialize/txt/zone.rs` (+2 -2) 📝 `crates/proto/src/https/https_client_stream.rs` (+16 -20) 📝 `crates/proto/src/op/edns.rs` (+6 -5) 📝 `crates/proto/src/op/message.rs` (+9 -0) 📝 `crates/proto/src/rr/dnssec/rdata/tsig.rs` (+3 -3) _...and 42 more files_ </details> ### 📄 Description @saethlin, I'm finally picking this back up. I restructured the directories in your fuzz layout, but otherwise this directly copies your work in #1606 closes: #1606 closes: #1605 Fixes: #1571 Fixes: #1570 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>