[PR #688] [MERGED] Add support for ECDSA signing with ring #1606

New issue

Closed

opened 2026-03-16 02:15:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:15:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/688
Author: @Darkspirit
Created: 2/17/2019
Status: ✅ Merged
Merged: 2/17/2019
Merged by: @bluejekyll

Base: master ← Head: ring_ecdsa

📝 Commits (1)

d05c826 Add support for ECDSA signing with ring

📊 Changes

8 files changed (+157 additions, -31 deletions)

View changed files

📝 crates/client/src/rr/dnssec/key_format.rs (+51 -27)
📝 crates/client/src/rr/dnssec/keypair.rs (+54 -4)
📝 crates/server/tests/named_test_configs/all_supported_dnssec.toml (+12 -0)
➕ crates/server/tests/named_test_configs/dnssec/ecdsa_p256.pk8 (+0 -0)
➕ crates/server/tests/named_test_configs/dnssec/ecdsa_p384.pk8 (+0 -0)
📝 crates/server/tests/named_test_configs/dnssec/gen-keys.sh (+6 -0)
📝 crates/server/tests/named_test_configs/ring_dnssec.toml (+12 -0)
📝 crates/server/tests/z_named_test_rsa_dnssec.rs (+22 -0)

📄 Description

It's live in action here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/688 **Author:** [@Darkspirit](https://github.com/Darkspirit) **Created:** 2/17/2019 **Status:** ✅ Merged **Merged:** 2/17/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `ring_ecdsa` --- ### 📝 Commits (1) - [`d05c826`](https://github.com/hickory-dns/hickory-dns/commit/d05c826833492415707a541f3813f21b695ed114) Add support for ECDSA signing with ring ### 📊 Changes **8 files changed** (+157 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/rr/dnssec/key_format.rs` (+51 -27) 📝 `crates/client/src/rr/dnssec/keypair.rs` (+54 -4) 📝 `crates/server/tests/named_test_configs/all_supported_dnssec.toml` (+12 -0) ➕ `crates/server/tests/named_test_configs/dnssec/ecdsa_p256.pk8` (+0 -0) ➕ `crates/server/tests/named_test_configs/dnssec/ecdsa_p384.pk8` (+0 -0) 📝 `crates/server/tests/named_test_configs/dnssec/gen-keys.sh` (+6 -0) 📝 `crates/server/tests/named_test_configs/ring_dnssec.toml` (+12 -0) 📝 `crates/server/tests/z_named_test_rsa_dnssec.rs` (+22 -0) </details> ### 📄 Description It's live in action [here](http://dnsviz.net/d/darkspirit.eu/dnssec/). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>