[PR #1625] [MERGED] Fix minimal dependency versions #2466

New issue

Closed

opened 2026-03-16 08:55:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:55:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1625
Author: @glts
Created: 2/3/2022
Status: ✅ Merged
Merged: 2/3/2022
Merged by: @djc

Base: main ← Head: min-versions

📝 Commits (1)

baaa390 Fix minimal dependency versions

📊 Changes

6 files changed (+8 additions, -8 deletions)

View changed files

📝 crates/async-std-resolver/Cargo.toml (+1 -1)
📝 crates/client/Cargo.toml (+1 -1)
📝 crates/proto/Cargo.toml (+2 -2)
📝 crates/resolver/Cargo.toml (+1 -1)
📝 crates/server/Cargo.toml (+1 -1)
📝 tests/integration-tests/Cargo.toml (+2 -2)

📄 Description

This is a small improvement that helps dependents build with minimal versions.

async-trait 0.1.42 → 0.1.43 (compile error in trust-dns-server with 0.1.42)
lazy_static 1.0 → 1.2.0 (compile error in trust-dns-proto with 1.0.0)

To find these version updates, I generated an app with cargo new and added a dependency one by one on each of the Trust-DNS packages, each time running cargo +nightly update -Z minimal-versions, followed by cargo check.

In the future, checking minimal dependency versions (if desired at all) could be done in CI. I cannot look into this for now, so tested this change manually. More could be done, but this seems like a sensible first step.

Note that there is also #919 for this, but there hasn’t been any activity there for a while.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1625 **Author:** [@glts](https://github.com/glts) **Created:** 2/3/2022 **Status:** ✅ Merged **Merged:** 2/3/2022 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `min-versions` --- ### 📝 Commits (1) - [`baaa390`](https://github.com/hickory-dns/hickory-dns/commit/baaa39072b76123f6e62d0d3f5ef5e280c21b6f3) Fix minimal dependency versions ### 📊 Changes **6 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `crates/async-std-resolver/Cargo.toml` (+1 -1) 📝 `crates/client/Cargo.toml` (+1 -1) 📝 `crates/proto/Cargo.toml` (+2 -2) 📝 `crates/resolver/Cargo.toml` (+1 -1) 📝 `crates/server/Cargo.toml` (+1 -1) 📝 `tests/integration-tests/Cargo.toml` (+2 -2) </details> ### 📄 Description This is a small improvement that helps dependents build with minimal versions. * async-trait `0.1.42` → `0.1.43` (compile error in trust-dns-server with 0.1.42) * lazy_static `1.0` → `1.2.0` (compile error in trust-dns-proto with 1.0.0) To find these version updates, I generated an app with `cargo new` and added a dependency one by one on each of the Trust-DNS packages, each time running `cargo +nightly update -Z minimal-versions`, followed by `cargo check`. In the future, checking minimal dependency versions (if desired at all) could be done in CI. I cannot look into this for now, so tested this change manually. More could be done, but this seems like a sensible first step. Note that there is also #919 for this, but there hasn’t been any activity there for a while. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>