[PR #712] [MERGED] Address #705 #1625

New issue

Closed

opened 2026-03-16 02:16:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:16:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/712
Author: @makarchuk
Created: 3/24/2019
Status: ✅ Merged
Merged: 3/25/2019
Merged by: @bluejekyll

Base: master ← Head: fix-no-newline-in-zonefile-issue

📝 Commits (5)

37f0cf9 Address #705
b51561c Merge branch 'master' into fix-no-newline-in-zonefile-issue
1c11c70 Remove redundant return
5f1c07e Optimize flush_records calls
528aa55 Merge branch 'master' into fix-no-newline-in-zonefile-issue

📊 Changes

3 files changed (+139 additions, -88 deletions)

View changed files

📝 crates/client/src/serialize/txt/master.rs (+101 -86)
➕ crates/server/tests/named_test_configs/default/nonewline.zone (+13 -0)
📝 crates/server/tests/store_file_tests.rs (+25 -2)

📄 Description

Add additional record flush in a lexer.

It will be useful if no newline was encountered and we still have a
record pending in a state object.

Added test to ensure that last is parsed correctly

Fixes: #705

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/712 **Author:** [@makarchuk](https://github.com/makarchuk) **Created:** 3/24/2019 **Status:** ✅ Merged **Merged:** 3/25/2019 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-no-newline-in-zonefile-issue` --- ### 📝 Commits (5) - [`37f0cf9`](https://github.com/hickory-dns/hickory-dns/commit/37f0cf996e1e71b4886750bb8b6d7e0ce3d348d8) Address #705 - [`b51561c`](https://github.com/hickory-dns/hickory-dns/commit/b51561c4bc2a8d003ad166cb4b9d748dc3940ff0) Merge branch 'master' into fix-no-newline-in-zonefile-issue - [`1c11c70`](https://github.com/hickory-dns/hickory-dns/commit/1c11c70abb716718ee606e61e25b4a03b6152236) Remove redundant return - [`5f1c07e`](https://github.com/hickory-dns/hickory-dns/commit/5f1c07e8c69d8b4034770b1b027c65fd20872190) Optimize `flush_records` calls - [`528aa55`](https://github.com/hickory-dns/hickory-dns/commit/528aa55f25d472a8d6b455bcd6e20f215d08a676) Merge branch 'master' into fix-no-newline-in-zonefile-issue ### 📊 Changes **3 files changed** (+139 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `crates/client/src/serialize/txt/master.rs` (+101 -86) ➕ `crates/server/tests/named_test_configs/default/nonewline.zone` (+13 -0) 📝 `crates/server/tests/store_file_tests.rs` (+25 -2) </details> ### 📄 Description Add additional record flush in a lexer. It will be useful if no newline was encountered and we still have a record pending in a state object. Added test to ensure that last is parsed correctly Fixes: #705 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>