[PR #1482] [MERGED] reduce size of ResolveErrorKind #2357

New issue

Closed

opened 2026-03-16 08:49:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:49:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1482
Author: @trinity-1686a
Created: 5/6/2021
Status: ✅ Merged
Merged: 5/9/2021
Merged by: @bluejekyll

Base: main ← Head: reduce-error-size

📝 Commits (4)

7e5bb62 reduce size of ResolveErrorKind
9d97351 fix clippy
13d41e4 fix clippy
8048d57 Merge branch 'main' into reduce-error-size

📊 Changes

8 files changed (+44 additions, -31 deletions)

View changed files

📝 bin/src/named.rs (+3 -3)
📝 bin/tests/server_harness/mod.rs (+17 -4)
📝 crates/client/src/serialize/txt/rdata_parsers/caa.rs (+1 -1)
📝 crates/client/src/serialize/txt/rdata_parsers/tlsa.rs (+1 -1)
📝 crates/resolver/src/caching_client.rs (+7 -7)
📝 crates/resolver/src/dns_lru.rs (+4 -4)
📝 crates/resolver/src/error.rs (+10 -10)
📝 crates/resolver/src/lookup.rs (+1 -1)

📄 Description

fix #1383 part2
Reduce size of ResolveError by boxing some parts of its inner enum
#1409 already boxed ProtoErrorKind in ProtoError

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1482 **Author:** [@trinity-1686a](https://github.com/trinity-1686a) **Created:** 5/6/2021 **Status:** ✅ Merged **Merged:** 5/9/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `reduce-error-size` --- ### 📝 Commits (4) - [`7e5bb62`](https://github.com/hickory-dns/hickory-dns/commit/7e5bb62a4eaf2fdf0819bbed59043b8010cf2ab4) reduce size of ResolveErrorKind - [`9d97351`](https://github.com/hickory-dns/hickory-dns/commit/9d97351caaf7f9800f1481cadfa3f783b2d49ae9) fix clippy - [`13d41e4`](https://github.com/hickory-dns/hickory-dns/commit/13d41e4a4a55bee1302ba3c08f952e2f6365a544) fix clippy - [`8048d57`](https://github.com/hickory-dns/hickory-dns/commit/8048d57b1ee575d871f25d3a9799b8f264537900) Merge branch 'main' into reduce-error-size ### 📊 Changes **8 files changed** (+44 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/named.rs` (+3 -3) 📝 `bin/tests/server_harness/mod.rs` (+17 -4) 📝 `crates/client/src/serialize/txt/rdata_parsers/caa.rs` (+1 -1) 📝 `crates/client/src/serialize/txt/rdata_parsers/tlsa.rs` (+1 -1) 📝 `crates/resolver/src/caching_client.rs` (+7 -7) 📝 `crates/resolver/src/dns_lru.rs` (+4 -4) 📝 `crates/resolver/src/error.rs` (+10 -10) 📝 `crates/resolver/src/lookup.rs` (+1 -1) </details> ### 📄 Description fix #1383 part2 Reduce size of `ResolveError` by boxing some parts of its inner enum #1409 already boxed `ProtoErrorKind` in `ProtoError` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>