[PR #352] [MERGED] Fix BinEncoder panic while writing Names into regions over u16::max_size() #1383

New issue

Closed

opened 2026-03-16 02:03:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:03:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/352
Author: @bluejekyll
Created: 2/27/2018
Status: ✅ Merged
Merged: 3/1/2018
Merged by: @bluejekyll

Base: master ← Head: fix_excessive_len_panic

📝 Commits (3)

47bd090 test to reproduce the issue
ed299ad enforce size limit on BinEncoder and underlying buffer
067f9a5 type safe maximum buffer size

📊 Changes

6 files changed (+231 additions, -49 deletions)

View changed files

📝 proto/src/error.rs (+8 -0)
📝 proto/src/op/edns.rs (+1 -1)
📝 proto/src/op/header.rs (+1 -1)
📝 proto/src/rr/domain/name.rs (+24 -0)
📝 proto/src/rr/resource.rs (+1 -1)
📝 proto/src/serialize/binary/encoder.rs (+196 -46)

📄 Description

partial fix for #351

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/352 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 2/27/2018 **Status:** ✅ Merged **Merged:** 3/1/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix_excessive_len_panic` --- ### 📝 Commits (3) - [`47bd090`](https://github.com/hickory-dns/hickory-dns/commit/47bd09075cddc7d84d486ce064906f01c0273910) test to reproduce the issue - [`ed299ad`](https://github.com/hickory-dns/hickory-dns/commit/ed299ad9c91913474dd77ec1f78b00953869990a) enforce size limit on BinEncoder and underlying buffer - [`067f9a5`](https://github.com/hickory-dns/hickory-dns/commit/067f9a5dac6ee44dc03d2c030c16b29a06b7ecf6) type safe maximum buffer size ### 📊 Changes **6 files changed** (+231 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `proto/src/error.rs` (+8 -0) 📝 `proto/src/op/edns.rs` (+1 -1) 📝 `proto/src/op/header.rs` (+1 -1) 📝 `proto/src/rr/domain/name.rs` (+24 -0) 📝 `proto/src/rr/resource.rs` (+1 -1) 📝 `proto/src/serialize/binary/encoder.rs` (+196 -46) </details> ### 📄 Description partial fix for #351 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>