[PR #1465] [MERGED] Fix panic on bad length for SVCB record #2341

New issue

Closed

opened 2026-03-16 08:48:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:48:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1465
Author: @bluejekyll
Created: 4/19/2021
Status: ✅ Merged
Merged: 4/20/2021
Merged by: @bluejekyll

Base: release/0.20 ← Head: fix-panic-svcb

📝 Commits (3)

0e919f9 Fix panic on bad length for SVCB record
e470202 fix clippy warnings
43167af fix formatting

📊 Changes

14 files changed (+30 additions, -17 deletions)

View changed files

📝 CHANGELOG.md (+6 -0)
📝 Makefile.toml (+1 -1)
📝 bin/src/named.rs (+1 -1)
📝 crates/client/src/lib.rs (+1 -1)
📝 crates/proto/src/lib.rs (+1 -1)
📝 crates/proto/src/rr/dnssec/rdata/mod.rs (+1 -1)
📝 crates/proto/src/rr/rdata/opt.rs (+2 -1)
📝 crates/proto/src/rr/rdata/svcb.rs (+11 -2)
📝 crates/proto/src/rr/record_data.rs (+1 -1)
📝 crates/proto/src/xfer/dns_request.rs (+1 -0)
📝 crates/resolver/src/lib.rs (+1 -5)
📝 crates/resolver/src/system_conf/unix.rs (+1 -1)
📝 crates/server/src/lib.rs (+1 -1)
📝 crates/server/src/store/in_memory/authority.rs (+1 -1)

📄 Description

@oherrala had the wrong branch in the other PR, this is correct.

Fixes the panic you discovered.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1465 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/19/2021 **Status:** ✅ Merged **Merged:** 4/20/2021 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `release/0.20` ← **Head:** `fix-panic-svcb` --- ### 📝 Commits (3) - [`0e919f9`](https://github.com/hickory-dns/hickory-dns/commit/0e919f9e255fe1ac4720811a5826ecaaea5da6d5) Fix panic on bad length for SVCB record - [`e470202`](https://github.com/hickory-dns/hickory-dns/commit/e4702028e78604a15acd4e5e9bebaea2826bd198) fix clippy warnings - [`43167af`](https://github.com/hickory-dns/hickory-dns/commit/43167af48dd805d7a9cb0a8e644b5ccc488d1325) fix formatting ### 📊 Changes **14 files changed** (+30 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+6 -0) 📝 `Makefile.toml` (+1 -1) 📝 `bin/src/named.rs` (+1 -1) 📝 `crates/client/src/lib.rs` (+1 -1) 📝 `crates/proto/src/lib.rs` (+1 -1) 📝 `crates/proto/src/rr/dnssec/rdata/mod.rs` (+1 -1) 📝 `crates/proto/src/rr/rdata/opt.rs` (+2 -1) 📝 `crates/proto/src/rr/rdata/svcb.rs` (+11 -2) 📝 `crates/proto/src/rr/record_data.rs` (+1 -1) 📝 `crates/proto/src/xfer/dns_request.rs` (+1 -0) 📝 `crates/resolver/src/lib.rs` (+1 -5) 📝 `crates/resolver/src/system_conf/unix.rs` (+1 -1) 📝 `crates/server/src/lib.rs` (+1 -1) 📝 `crates/server/src/store/in_memory/authority.rs` (+1 -1) </details> ### 📄 Description @oherrala had the wrong branch in the other PR, this is correct. Fixes the panic you discovered. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>