[PR #474] [MERGED] Migrate proto from error-chain to failure #1465

New issue

Closed

opened 2026-03-16 02:07:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:07:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/474
Author: @silwol
Created: 5/18/2018
Status: ✅ Merged
Merged: 5/18/2018
Merged by: @bluejekyll

Base: master ← Head: dev/326

📝 Commits (2)

5b9ed68 Migrate proto from error-chain to failure
a3a702f Use Fromipconfig::error::Error on Windows only

📊 Changes

53 files changed (+1272 additions, -840 deletions)

View changed files

📝 client/Cargo.toml (+1 -1)
📝 client/src/client/client.rs (+3 -1)
📝 client/src/error/client_error.rs (+133 -64)
📝 client/src/error/dnssec_error.rs (+132 -45)
📝 client/src/error/lexer_error.rs (+101 -69)
📝 client/src/error/mod.rs (+6 -10)
📝 client/src/error/parse_error.rs (+175 -59)
📝 client/src/lib.rs (+1 -1)
📝 client/src/rr/dnssec/mod.rs (+1 -2)
📝 client/src/serialize/txt/master.rs (+2 -2)
📝 client/src/serialize/txt/master_lex.rs (+1 -1)
📝 integration-tests/src/authority.rs (+17 -8)
📝 integration-tests/tests/client_future_tests.rs (+2 -5)
📝 integration-tests/tests/client_tests.rs (+2 -6)
📝 proto/Cargo.toml (+1 -1)
📝 proto/src/error.rs (+272 -208)
📝 proto/src/lib.rs (+1 -1)
📝 proto/src/op/message.rs (+4 -21)
📝 proto/src/op/op_code.rs (+1 -1)
📝 proto/src/rr/dnssec/digest_type.rs (+3 -7)

...and 33 more files

📄 Description

Closes: #326

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/474 **Author:** [@silwol](https://github.com/silwol) **Created:** 5/18/2018 **Status:** ✅ Merged **Merged:** 5/18/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `dev/326` --- ### 📝 Commits (2) - [`5b9ed68`](https://github.com/hickory-dns/hickory-dns/commit/5b9ed681444c5094193677a86e286bf8c1e6d184) Migrate proto from error-chain to failure - [`a3a702f`](https://github.com/hickory-dns/hickory-dns/commit/a3a702f2e681e361be090bdcbc8db4dfc2505484) Use From<ipconfig::error::Error> on Windows only ### 📊 Changes **53 files changed** (+1272 additions, -840 deletions) <details> <summary>View changed files</summary> 📝 `client/Cargo.toml` (+1 -1) 📝 `client/src/client/client.rs` (+3 -1) 📝 `client/src/error/client_error.rs` (+133 -64) 📝 `client/src/error/dnssec_error.rs` (+132 -45) 📝 `client/src/error/lexer_error.rs` (+101 -69) 📝 `client/src/error/mod.rs` (+6 -10) 📝 `client/src/error/parse_error.rs` (+175 -59) 📝 `client/src/lib.rs` (+1 -1) 📝 `client/src/rr/dnssec/mod.rs` (+1 -2) 📝 `client/src/serialize/txt/master.rs` (+2 -2) 📝 `client/src/serialize/txt/master_lex.rs` (+1 -1) 📝 `integration-tests/src/authority.rs` (+17 -8) 📝 `integration-tests/tests/client_future_tests.rs` (+2 -5) 📝 `integration-tests/tests/client_tests.rs` (+2 -6) 📝 `proto/Cargo.toml` (+1 -1) 📝 `proto/src/error.rs` (+272 -208) 📝 `proto/src/lib.rs` (+1 -1) 📝 `proto/src/op/message.rs` (+4 -21) 📝 `proto/src/op/op_code.rs` (+1 -1) 📝 `proto/src/rr/dnssec/digest_type.rs` (+3 -7) _...and 33 more files_ </details> ### 📄 Description Closes: #326 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>