[PR #1373] [MERGED] Enable RuntimeProvider in DoT implementations #2267

New issue

Closed

opened 2026-03-16 08:29:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 08:29:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1373
Author: @kmod-midori
Created: 2/3/2021
Status: ✅ Merged
Merged: 2/3/2021
Merged by: @djc

Base: main ← Head: tls-provider

📝 Commits (5)

e84e67c Make Rustls respect RuntimeProvider
7be8e7c Add to native TLS
9198206 Add OpenSSL
d751b41 Make clippy happy
1fedd27 Fix use style

📊 Changes

17 files changed (+142 additions, -94 deletions)

View changed files

📝 bin/tests/named_openssl_tests.rs (+6 -2)
📝 bin/tests/named_rustls_tests.rs (+12 -3)
📝 crates/native-tls/src/tests.rs (+3 -1)
📝 crates/native-tls/src/tls_client_stream.rs (+9 -8)
📝 crates/native-tls/src/tls_stream.rs (+17 -15)
📝 crates/openssl/src/tls_client_stream.rs (+8 -7)
📝 crates/openssl/src/tls_stream.rs (+18 -15)
📝 crates/openssl/tests/openssl_tests.rs (+6 -3)
📝 crates/resolver/src/name_server/connection_provider.rs (+11 -10)
📝 crates/resolver/src/tls/dns_over_native_tls.rs (+4 -2)
📝 crates/resolver/src/tls/dns_over_openssl.rs (+4 -2)
📝 crates/resolver/src/tls/dns_over_rustls.rs (+3 -2)
📝 crates/rustls/src/tests.rs (+7 -1)
📝 crates/rustls/src/tls_client_stream.rs (+6 -6)
📝 crates/rustls/src/tls_stream.rs (+13 -9)
📝 tests/integration-tests/src/tls_client_connection.rs (+10 -7)
📝 tests/integration-tests/tests/server_future_tests.rs (+5 -1)

📄 Description

I was surprised that RuntimeProvider does not work in DoT, which is not ideal for my application.

Most changes of this PR are just playing around with types, almost no changes have been made to the logic.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1373 **Author:** [@kmod-midori](https://github.com/kmod-midori) **Created:** 2/3/2021 **Status:** ✅ Merged **Merged:** 2/3/2021 **Merged by:** [@djc](https://github.com/djc) **Base:** `main` ← **Head:** `tls-provider` --- ### 📝 Commits (5) - [`e84e67c`](https://github.com/hickory-dns/hickory-dns/commit/e84e67c1d8a9a669e30e2fd62d937f9a8ac24e66) Make Rustls respect RuntimeProvider - [`7be8e7c`](https://github.com/hickory-dns/hickory-dns/commit/7be8e7c1868b09e86bc6247971238b0b903b1636) Add to native TLS - [`9198206`](https://github.com/hickory-dns/hickory-dns/commit/919820679621ddc8a7e7bb8ffc90b4da3fcc0ddf) Add OpenSSL - [`d751b41`](https://github.com/hickory-dns/hickory-dns/commit/d751b41d8bca250a80478c1ff9fc8fa17465757c) Make clippy happy - [`1fedd27`](https://github.com/hickory-dns/hickory-dns/commit/1fedd276c437d87bbc19b87087c5e1c56a2aadac) Fix `use` style ### 📊 Changes **17 files changed** (+142 additions, -94 deletions) <details> <summary>View changed files</summary> 📝 `bin/tests/named_openssl_tests.rs` (+6 -2) 📝 `bin/tests/named_rustls_tests.rs` (+12 -3) 📝 `crates/native-tls/src/tests.rs` (+3 -1) 📝 `crates/native-tls/src/tls_client_stream.rs` (+9 -8) 📝 `crates/native-tls/src/tls_stream.rs` (+17 -15) 📝 `crates/openssl/src/tls_client_stream.rs` (+8 -7) 📝 `crates/openssl/src/tls_stream.rs` (+18 -15) 📝 `crates/openssl/tests/openssl_tests.rs` (+6 -3) 📝 `crates/resolver/src/name_server/connection_provider.rs` (+11 -10) 📝 `crates/resolver/src/tls/dns_over_native_tls.rs` (+4 -2) 📝 `crates/resolver/src/tls/dns_over_openssl.rs` (+4 -2) 📝 `crates/resolver/src/tls/dns_over_rustls.rs` (+3 -2) 📝 `crates/rustls/src/tests.rs` (+7 -1) 📝 `crates/rustls/src/tls_client_stream.rs` (+6 -6) 📝 `crates/rustls/src/tls_stream.rs` (+13 -9) 📝 `tests/integration-tests/src/tls_client_connection.rs` (+10 -7) 📝 `tests/integration-tests/tests/server_future_tests.rs` (+5 -1) </details> ### 📄 Description I was surprised that `RuntimeProvider` does not work in DoT, which is not ideal for my application. Most changes of this PR are just playing around with types, almost no changes have been made to the logic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>