[PR #337] [MERGED] support mDNS #1373

New issue

Closed

opened 2026-03-16 02:02:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 02:02:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/337
Author: @bluejekyll
Created: 2/8/2018
Status: ✅ Merged
Merged: 3/18/2018
Merged by: @bluejekyll

Base: master ← Head: support_mdns

📝 Commits (10+)

1240284 initial mDNS streams
b054bdd mdns OneShot tests
a041cde add mDNS stream tests
16272c6 trying to make mDNS tests more resilient
ff8249b first successful mdns test
a9ad4e9 Cleanup ClientConnection by adding better restriction
ae6d83d restructure mdns_stream to split sending/recieving sockets
66a2180 fix srv.rs doc string
269a9e7 add responder to integration test
26cb371 cleanup mDNS tests

📊 Changes

24 files changed (+1395 additions, -63 deletions)

View changed files

📝 .travis.yml (+13 -0)
📝 Cargo.lock (+18 -15)
📝 client/Cargo.toml (+3 -0)
📝 client/src/client/client.rs (+0 -8)
📝 client/src/client/client_connection.rs (+2 -2)
📝 client/src/lib.rs (+3 -1)
➕ client/src/multicast/mdns_client_connection.rs (+77 -0)
➕ client/src/multicast/mod.rs (+14 -0)
📝 compatibility-tests/tests/sig0_tests.rs (+0 -3)
📝 integration-tests/Cargo.toml (+5 -0)
📝 integration-tests/tests/client_future_tests.rs (+0 -12)
📝 integration-tests/tests/client_tests.rs (+1 -5)
➕ integration-tests/tests/mdns_tests.rs (+172 -0)
📝 proto/Cargo.toml (+7 -0)
📝 proto/src/lib.rs (+6 -3)
➕ proto/src/multicast/mdns_client_stream.rs (+127 -0)
➕ proto/src/multicast/mdns_stream.rs (+755 -0)
➕ proto/src/multicast/mod.rs (+68 -0)
📝 proto/src/rr/domain/usage.rs (+70 -0)
📝 proto/src/rr/rdata/srv.rs (+1 -0)

...and 4 more files

📄 Description

Fixes #24
Fixes #353

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/337 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 2/8/2018 **Status:** ✅ Merged **Merged:** 3/18/2018 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `support_mdns` --- ### 📝 Commits (10+) - [`1240284`](https://github.com/hickory-dns/hickory-dns/commit/1240284b17f1059a81ccc2217df11210a2f4233c) initial mDNS streams - [`b054bdd`](https://github.com/hickory-dns/hickory-dns/commit/b054bdd22afb5eda0aac8d9f97daac1d277023b6) mdns OneShot tests - [`a041cde`](https://github.com/hickory-dns/hickory-dns/commit/a041cdee72f3e2fafe8302bfebff016994d3f6a4) add mDNS stream tests - [`16272c6`](https://github.com/hickory-dns/hickory-dns/commit/16272c601f412db02b2282e3b8c74b5214a3478d) trying to make mDNS tests more resilient - [`ff8249b`](https://github.com/hickory-dns/hickory-dns/commit/ff8249b21128e84e895f5b8ef52f6b07c207001d) first successful mdns test - [`a9ad4e9`](https://github.com/hickory-dns/hickory-dns/commit/a9ad4e9431f247ed7e6e560902759fcf2ac5c8dd) Cleanup ClientConnection by adding better restriction - [`ae6d83d`](https://github.com/hickory-dns/hickory-dns/commit/ae6d83d15d81eef523da51a5180624c762d419b3) restructure mdns_stream to split sending/recieving sockets - [`66a2180`](https://github.com/hickory-dns/hickory-dns/commit/66a21804dfb47471d577179e6f328cf4bf530b24) fix srv.rs doc string - [`269a9e7`](https://github.com/hickory-dns/hickory-dns/commit/269a9e70f7c17e7a2205b985f07bf2c784388075) add responder to integration test - [`26cb371`](https://github.com/hickory-dns/hickory-dns/commit/26cb37180e2d26d4ac98ff3ba3af0e3dae22483e) cleanup mDNS tests ### 📊 Changes **24 files changed** (+1395 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+13 -0) 📝 `Cargo.lock` (+18 -15) 📝 `client/Cargo.toml` (+3 -0) 📝 `client/src/client/client.rs` (+0 -8) 📝 `client/src/client/client_connection.rs` (+2 -2) 📝 `client/src/lib.rs` (+3 -1) ➕ `client/src/multicast/mdns_client_connection.rs` (+77 -0) ➕ `client/src/multicast/mod.rs` (+14 -0) 📝 `compatibility-tests/tests/sig0_tests.rs` (+0 -3) 📝 `integration-tests/Cargo.toml` (+5 -0) 📝 `integration-tests/tests/client_future_tests.rs` (+0 -12) 📝 `integration-tests/tests/client_tests.rs` (+1 -5) ➕ `integration-tests/tests/mdns_tests.rs` (+172 -0) 📝 `proto/Cargo.toml` (+7 -0) 📝 `proto/src/lib.rs` (+6 -3) ➕ `proto/src/multicast/mdns_client_stream.rs` (+127 -0) ➕ `proto/src/multicast/mdns_stream.rs` (+755 -0) ➕ `proto/src/multicast/mod.rs` (+68 -0) 📝 `proto/src/rr/domain/usage.rs` (+70 -0) 📝 `proto/src/rr/rdata/srv.rs` (+1 -0) _...and 4 more files_ </details> ### 📄 Description Fixes #24 Fixes #353 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>