[PR #1265] [CLOSED] Update high ResponseCode in EDNS Section if required #2147

New issue

Closed

opened 2026-03-16 06:22:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 06:22:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1265
Author: @jonasbb
Created: 10/26/2020
Status: ❌ Closed

Base: main ← Head: issue1203

📝 Commits (1)

ddd25a5 Update high ResponseCode in EDNS Section if required

📊 Changes

3 files changed (+55 additions, -7 deletions)

View changed files

📝 crates/proto/src/op/header.rs (+3 -0)
📝 crates/proto/src/op/message.rs (+22 -6)
📝 crates/server/src/authority/message_response.rs (+30 -1)

📄 Description

Some ResponseCodes have high bits which require EDNS to encode them.
This commit updates Message::set_response_code and
MessageResponseBuiler::error_msg to silently create a EDNS section if
required and sets the high bits there.

This also adds a warning to Header::set_response_code that this function
cannot set the high bits.

Closes #1203
Closes #1207

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1265 **Author:** [@jonasbb](https://github.com/jonasbb) **Created:** 10/26/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `issue1203` --- ### 📝 Commits (1) - [`ddd25a5`](https://github.com/hickory-dns/hickory-dns/commit/ddd25a5545130cd2684f3470f25adb2312fe8029) Update high ResponseCode in EDNS Section if required ### 📊 Changes **3 files changed** (+55 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `crates/proto/src/op/header.rs` (+3 -0) 📝 `crates/proto/src/op/message.rs` (+22 -6) 📝 `crates/server/src/authority/message_response.rs` (+30 -1) </details> ### 📄 Description Some ResponseCodes have high bits which require EDNS to encode them. This commit updates Message::set_response_code and MessageResponseBuiler::error_msg to silently create a EDNS section if required and sets the high bits there. This also adds a warning to Header::set_response_code that this function cannot set the high bits. Closes #1203 Closes #1207 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>