[PR #49] [CLOSED] Resolved all of the compiler warnings #1207

New issue

Closed

opened 2026-03-16 01:54:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:54:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/49
Author: @chaoticsmol
Created: 10/9/2016
Status: ❌ Closed

Base: master ← Head: resolve-warnings

📝 Commits (3)

ac0bec9 Resolved all of the compiler warnings
e23e6a1 Added back in imports that were being complained about but where actually needed for running the build
020e0ca Resolved warnings for cargo test as well as cargo build

📊 Changes

3 files changed (+38 additions, -33 deletions)

View changed files

📝 src/client/client_future.rs (+20 -13)
📝 src/tcp/tcp_client_stream.rs (+16 -19)
📝 src/udp/udp_client_stream.rs (+2 -1)

📄 Description

There were a handful of compiler warnings being generated mostly related to some unused functions and imports. I removed the unused imports and set the #[allow(dead_code)] attribute on functions and struct fields that should be left in the library for users but not trigger warnings for their lack of use within the library itself.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/49 **Author:** [@chaoticsmol](https://github.com/chaoticsmol) **Created:** 10/9/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `resolve-warnings` --- ### 📝 Commits (3) - [`ac0bec9`](https://github.com/hickory-dns/hickory-dns/commit/ac0bec93e0a81553e96f28698ef7c992d3cc0b13) Resolved all of the compiler warnings - [`e23e6a1`](https://github.com/hickory-dns/hickory-dns/commit/e23e6a1cbf9ea45a5cad922820bf0e9ea0ae7400) Added back in imports that were being complained about but where actually needed for running the build - [`020e0ca`](https://github.com/hickory-dns/hickory-dns/commit/020e0ca2597934c004cb164456c5fb9e084703f8) Resolved warnings for cargo test as well as cargo build ### 📊 Changes **3 files changed** (+38 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/client/client_future.rs` (+20 -13) 📝 `src/tcp/tcp_client_stream.rs` (+16 -19) 📝 `src/udp/udp_client_stream.rs` (+2 -1) </details> ### 📄 Description There were a handful of compiler warnings being generated mostly related to some unused functions and imports. I removed the unused imports and set the `#[allow(dead_code)]` attribute on functions and struct fields that should be left in the library for users but not trigger warnings for their lack of use within the library itself. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>