starred/hickory-dns
1
0
Fork 0
mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00
Code Issues 373 Projects Releases 6 Packages Wiki Activity

[PR #1262] [MERGED] Upgrade to Tokio 0.3 #2142

New issue
Closed
opened 2026-03-16 06:22:34 +03:00 by kerem · 0 comments
kerem commented 2026-03-16 06:22:34 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1262
Author: @bluejekyll
Created: 10/24/2020
Status: ✅ Merged
Merged: 11/29/2020
Merged by: @bluejekyll

Base: main ← Head: upgrade-to-tokio-0.3

📝 Commits (10+)

  • 657ce88 upgrade proto crate to Tokio 0.3
  • 519b9c3 upgrade trust-dns-rustls to tokio 0.3
  • 9b55daf temporary implementation of trust-dns-https for Tokio 0.3
  • 80be0ca upgrade trust-dns-client to Tokio 0.3
  • ef18434 upgrade trust-dns-openssl to Tokio 0.3
  • ab3b94b upgrade trust-dns-native-tls to Tokio 0.3
  • 89f4dea upgrade trust-dns-resolver to Tokio 0.3
  • c610f1c upgrade trust-dns-server to Tokio 0.3
  • 8bfb1e4 upgrade trust-dns to Tokio 0.3
  • 91a2980 upgrade integration tests to Tokio 0.3

📊 Changes

77 files changed (+703 additions, -702 deletions)

View changed files

📝 .github/workflows/test.yml (+1 -1)
📝 CHANGELOG.md (+2 -1)
📝 Cargo.lock (+176 -212)
📝 Cargo.toml (+5 -0)
📝 README.md (+1 -1)
📝 bin/Cargo.toml (+3 -3)
📝 bin/README.md (+1 -1)
📝 bin/benches/comparison_benches.rs (+5 -5)
📝 bin/src/named.rs (+20 -32)
📝 bin/tests/named_https_tests.rs (+2 -2)
📝 bin/tests/named_test_rsa_dnssec.rs (+3 -3)
📝 bin/tests/named_tests.rs (+15 -15)
📝 bin/tests/server_harness/mod.rs (+3 -1)
📝 crates/async-std-resolver/Cargo.toml (+2 -0)
📝 crates/async-std-resolver/README.md (+1 -1)
📝 crates/async-std-resolver/src/net.rs (+29 -3)
📝 crates/client/Cargo.toml (+2 -2)
📝 crates/client/README.md (+1 -1)
📝 crates/client/src/client/client.rs (+10 -11)
📝 crates/client/src/tcp/tcp_client_connection.rs (+9 -8)

...and 57 more files

📄 Description

Need to upgrade all crates:

  • proto
  • rustls - depends on tokio-rustls
  • https - dependecies on tokio-rustls, et al. (tests failing, temp impl on git master branch from h2)
  • client
  • openssl - depends on tokio-openssl
  • native-tls - requires move to tokio-native-tls
  • resolver
  • server
  • bin
  • util
  • tests

Fixes: #1250

blocked on:

  • test failure: https_client_stream::tests::test_https_google in trust-dns-https
  • h2 0.3 release with upgrade to Tokio 0.3, will fix this on release of 0.20.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1262 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 10/24/2020 **Status:** ✅ Merged **Merged:** 11/29/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `upgrade-to-tokio-0.3` --- ### 📝 Commits (10+) - [`657ce88`](https://github.com/hickory-dns/hickory-dns/commit/657ce88612dc82cc99fc4bff15a179df183f022c) upgrade proto crate to Tokio 0.3 - [`519b9c3`](https://github.com/hickory-dns/hickory-dns/commit/519b9c3ce8d853d6e132bc3301cedbc0a458bc2e) upgrade trust-dns-rustls to tokio 0.3 - [`9b55daf`](https://github.com/hickory-dns/hickory-dns/commit/9b55daf45264a1fb3f8f609d092cf3b305c93fab) temporary implementation of trust-dns-https for Tokio 0.3 - [`80be0ca`](https://github.com/hickory-dns/hickory-dns/commit/80be0cae621a8c7bd034683ebb7521ea447a1623) upgrade trust-dns-client to Tokio 0.3 - [`ef18434`](https://github.com/hickory-dns/hickory-dns/commit/ef18434b43a8f9aefd4af189111ed1d29a829f37) upgrade trust-dns-openssl to Tokio 0.3 - [`ab3b94b`](https://github.com/hickory-dns/hickory-dns/commit/ab3b94b38b6aea501429d4e6181075b9268fc7b1) upgrade trust-dns-native-tls to Tokio 0.3 - [`89f4dea`](https://github.com/hickory-dns/hickory-dns/commit/89f4dea9742f536d0ef3335d78b42d3e4dcf7a30) upgrade trust-dns-resolver to Tokio 0.3 - [`c610f1c`](https://github.com/hickory-dns/hickory-dns/commit/c610f1cf854b7ffb5b350d433c64e9e3b8ef50c5) upgrade trust-dns-server to Tokio 0.3 - [`8bfb1e4`](https://github.com/hickory-dns/hickory-dns/commit/8bfb1e47cb3c438bfb37b393b7cd83ce6e63a5f9) upgrade trust-dns to Tokio 0.3 - [`91a2980`](https://github.com/hickory-dns/hickory-dns/commit/91a2980748aeddceca4df73b2451df3cf6746924) upgrade integration tests to Tokio 0.3 ### 📊 Changes **77 files changed** (+703 additions, -702 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+1 -1) 📝 `CHANGELOG.md` (+2 -1) 📝 `Cargo.lock` (+176 -212) 📝 `Cargo.toml` (+5 -0) 📝 `README.md` (+1 -1) 📝 `bin/Cargo.toml` (+3 -3) 📝 `bin/README.md` (+1 -1) 📝 `bin/benches/comparison_benches.rs` (+5 -5) 📝 `bin/src/named.rs` (+20 -32) 📝 `bin/tests/named_https_tests.rs` (+2 -2) 📝 `bin/tests/named_test_rsa_dnssec.rs` (+3 -3) 📝 `bin/tests/named_tests.rs` (+15 -15) 📝 `bin/tests/server_harness/mod.rs` (+3 -1) 📝 `crates/async-std-resolver/Cargo.toml` (+2 -0) 📝 `crates/async-std-resolver/README.md` (+1 -1) 📝 `crates/async-std-resolver/src/net.rs` (+29 -3) 📝 `crates/client/Cargo.toml` (+2 -2) 📝 `crates/client/README.md` (+1 -1) 📝 `crates/client/src/client/client.rs` (+10 -11) 📝 `crates/client/src/tcp/tcp_client_connection.rs` (+9 -8) _...and 57 more files_ </details> ### 📄 Description Need to upgrade all crates: - [x] proto - [x] rustls - depends on tokio-rustls - [x] https - dependecies on tokio-rustls, et al. (tests failing, temp impl on git master branch from h2) - [x] client - [x] openssl - depends on tokio-openssl - [x] native-tls - requires move to tokio-native-tls - [x] resolver - [x] server - [x] bin - [x] util - [x] tests Fixes: #1250 blocked on: - [x] test failure: https_client_stream::tests::test_https_google in trust-dns-https - [ ] ~~h2 0.3 release with upgrade to Tokio 0.3~~, will fix this on release of `0.20`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 06:22:34 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
david/conformance-dnssec-negative-tests
prepare-0.26.1
release/0.26
query-api
opt-types
cname-nsec
no-cname-recursion
conformance-min-ttl
dname-base
drop-message-request
no-error-queries
cpu-sig0-rm-message-sig_dev
cpu-tsig-test-update_dev
windows-config
dnssec-net
release/0.25
opp-enc-persist
integration-test
cpu-tidying-recursor-opts_dev
happy-eyeballs
david/authoritative-zone-storage-trait
dnssec-ad
no-authority
release/0.24
pvdrz/remove-top-file
pvdrz/h3-handshake-timeout
pvdrz/quic-handshake-timeout
nxdomain-for-recursor
ja-test-merque-queue
ja-fix-ci-again
sz-add-ede-tests
sz-test-tc-bit-with-large-response
sz-fix-tokio-dependency
gh-2275-test-rrsig-signature
refactor-sign-zone-file
fix-1.79-cleanliness
update-nightly-hash
release/0.23
gh-pages
use-just-for-server-toml
release/0.22
revert-1874-cpu-zone-parse-default-class
disable-bind-compatibility-tests
disable-test_tls_client_stream_ipv4
update-native-tls-0.2.11
recursor-tests
fix-clippy-self
release/0.20
saethlin-fix-rdata-zero
release/0.19
flat_name
drop_unused_futures
release/0.18
release-r0.12-cs0.17
release/r0.12-cs0.17
trust-dns-book
r0.10
test-connections-not-dropped
fix_exec_status_on_rs_files
release-0.9
add-mutex-to-integration-tests
0.8_release
bfry/dns-crypt
v0.26.0
v0.26.0-beta.4
v0.26.0-beta.3
v0.26.0-beta.2
v0.26.0-beta.1
v0.26.0-alpha.1
v0.25.2
v0.25.1
v0.25.0
v0.24.4
v0.24.3
v0.25.0-alpha.5
v0.24.2
v0.25.0-alpha.4
v0.25.0-alpha.3
v0.25.0-alpha.2
v0.25.0-alpha.1
v0.24.1
v0.23.2
v0.24.0
v0.23.1
v0.23.0
v0.23.0-alpha.5
v0.23.0-alpha.4
v0.23.0-alpha.3
v0.22.1
v0.23.0-alpha.2
v0.23.0-alpha.1
v0.22.0
v0.21.2
v0.21.1
v0.21.0
v0.21.0-alpha.5
v0.20.4
v0.21.0-alpha.4
v0.21.0-alpha.3
v0.21.0-alpha.2
v0.21.0-alpha.1
v0.20.3
v0.20.2
v0.20.1
v0.19.7
v0.20.0
0.19.6
v0.20.0-alpha.3
v0.20.0-alpha.2
v0.20.0-alpha.1
0.19.5
0.19.4
0.19.3
0.19.0
0.18.1
0.18
0.18.0.alpha.2
r0.12_cs0.17
r0.11.1
cs0.16.1
r0.11
cs0.16
r0.10.1
r0.10.0
cs0.15.0
r0.9.1
v0.14.0
r0.9.0
r0.8.1
r0.8.0
v0.13.0
r0.7.0
c0.12.0
r0.6.0
r0.5.0
resolver.0.4.0
0.11.0
0.10.5
0.10.4
0.10.3
0.10.2
0.10.1
0.10.0
0.9.3
0.9.2
0.9.1
0.9.0
0.8.1
0.8.0
0.7.3
0.7.2
0.7.1
0.7.0
0.6.0
0.5.3
0.5.1
0.5.0
0.4.0
0.3.1
0.3.0
0.2.1
0.2.0
0.1.0
Labels
Clear labels   
blocked

   
breaking-change

   
bug

   
bug:critical

   
bug:tests

   
cleanup

   
compliance

   
compliance

   
compliance

   
crate:all

   
crate:client

   
crate:native-tls

   
crate:proto

   
crate:recursor

   
crate:resolver

   
crate:resolver

   
crate:rustls

   
crate:server

   
crate:util

   
dependencies

   
docs

   
duplicate

   
easy

   
easy

   
enhance

   
enhance

   
enhance

   
feature:dns-over-https

   
feature:dns-over-quic

   
feature:dns-over-tls

   
feature:dnsssec

   
feature:global_lb

   
feature:mdns

   
feature:tsig

   
features:edns

   
has workaround

   
ops

   
perf

   
platform:WASM

   
platform:android

   
platform:fuchsia

   
platform:linux

   
platform:macos

   
platform:windows

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
test

   
tools

   
tools

   
trust

   
unclear

   
wontfix
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2142
No description provided.