[PR #119] [MERGED] Support KEY flags and fix sig0 signing algorithm #1250

New issue

Closed

opened 2026-03-16 01:56:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:56:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/119
Author: @bluejekyll
Created: 4/23/2017
Status: ✅ Merged
Merged: 5/7/2017
Merged by: @bluejekyll

Base: master ← Head: key_flags

📝 Commits (4)

1a04ece support KEY flags
a9fca20 Deprecate Protocol flags in KEY records
21e636c Fix SIG(0) calculation (#122)
4d898ce BIND sig0 create test passing

📊 Changes

37 files changed (+1798 additions, -666 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 Cargo.lock (+60 -87)
📝 client/src/client/client.rs (+3 -1)
📝 client/src/client/mod.rs (+2 -0)
📝 client/src/client/secure_client_handle.rs (+66 -44)
📝 client/src/error/dnssec_error.rs (+3 -0)
📝 client/src/op/message.rs (+17 -20)
📝 client/src/rr/dnssec/digest_type.rs (+3 -3)
📝 client/src/rr/dnssec/key_format.rs (+23 -42)
📝 client/src/rr/dnssec/keypair.rs (+50 -27)
📝 client/src/rr/dnssec/nsec3.rs (+6 -3)
📝 client/src/rr/dnssec/signer.rs (+127 -49)
📝 client/src/rr/dnssec/trust_anchor.rs (+1 -0)
📝 client/src/rr/rdata/dnskey.rs (+47 -29)
📝 client/src/rr/rdata/ds.rs (+1 -1)
➕ client/src/rr/rdata/key.rs (+837 -0)
📝 client/src/rr/rdata/mod.rs (+3 -1)
📝 client/src/rr/rdata/sig.rs (+23 -0)
📝 client/src/rr/record_data.rs (+7 -19)
📝 compatibility/Cargo.toml (+1 -1)

...and 17 more files

📄 Description

Add support for all the flags of KEY, and split DNSKEY from KEY

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/119 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 4/23/2017 **Status:** ✅ Merged **Merged:** 5/7/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `key_flags` --- ### 📝 Commits (4) - [`1a04ece`](https://github.com/hickory-dns/hickory-dns/commit/1a04ece9a224460d5b028652f2ac7be1b94d4e3d) support KEY flags - [`a9fca20`](https://github.com/hickory-dns/hickory-dns/commit/a9fca20e15b7790ce40440182f70c9e94293d8b1) Deprecate Protocol flags in KEY records - [`21e636c`](https://github.com/hickory-dns/hickory-dns/commit/21e636ce1b7515c93088a5d1b5a7cc84f3b27c31) Fix SIG(0) calculation (#122) - [`4d898ce`](https://github.com/hickory-dns/hickory-dns/commit/4d898ce4dd222f48190dd61c322aef3ab1ba6903) BIND sig0 create test passing ### 📊 Changes **37 files changed** (+1798 additions, -666 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.lock` (+60 -87) 📝 `client/src/client/client.rs` (+3 -1) 📝 `client/src/client/mod.rs` (+2 -0) 📝 `client/src/client/secure_client_handle.rs` (+66 -44) 📝 `client/src/error/dnssec_error.rs` (+3 -0) 📝 `client/src/op/message.rs` (+17 -20) 📝 `client/src/rr/dnssec/digest_type.rs` (+3 -3) 📝 `client/src/rr/dnssec/key_format.rs` (+23 -42) 📝 `client/src/rr/dnssec/keypair.rs` (+50 -27) 📝 `client/src/rr/dnssec/nsec3.rs` (+6 -3) 📝 `client/src/rr/dnssec/signer.rs` (+127 -49) 📝 `client/src/rr/dnssec/trust_anchor.rs` (+1 -0) 📝 `client/src/rr/rdata/dnskey.rs` (+47 -29) 📝 `client/src/rr/rdata/ds.rs` (+1 -1) ➕ `client/src/rr/rdata/key.rs` (+837 -0) 📝 `client/src/rr/rdata/mod.rs` (+3 -1) 📝 `client/src/rr/rdata/sig.rs` (+23 -0) 📝 `client/src/rr/record_data.rs` (+7 -19) 📝 `compatibility/Cargo.toml` (+1 -1) _...and 17 more files_ </details> ### 📄 Description Add support for all the flags of KEY, and split DNSKEY from KEY --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>