[GH-ISSUE #511] Answers should use original query names, not what's in the catalog #211

New issue

Closed

opened 2026-03-07 22:49:50 +03:00 by kerem · 4 comments

kerem commented

2026-03-07 22:49:50 +03:00

Owner

Originally created by @rushmorem on GitHub (Jun 12, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/511

To preserve case of the original query name
So as not to return characters such as * that may be in the catalog

Originally created by @rushmorem on GitHub (Jun 12, 2018). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/511 - To preserve case of the original query name - So as not to return characters such as `*` that may be in the catalog

kerem

2026-03-07 22:49:50 +03:00

closed this issue
added the
bug

crate:server
labels

kerem commented

2026-03-07 22:50:06 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jun 12, 2018):

Ah, interesting. This may be in a bit of conflict with the current model of Iterators used for response collection.

Basically I converted the return path to not clone on any return, and Records carry the Name from the server.

@bluejekyll commented on GitHub (Jun 12, 2018): Ah, interesting. This may be in a bit of conflict with the current model of Iterators used for response collection. Basically I converted the return path to not clone on any return, and Records carry the Name from the server.

kerem commented

2026-03-07 22:50:11 +03:00

Author

Owner

@rushmorem commented on GitHub (Jun 12, 2018):

Yeah, I noticed. That should help with memory usage.

@rushmorem commented on GitHub (Jun 12, 2018): Yeah, I noticed. That should help with memory usage.

kerem commented

2026-03-07 22:50:16 +03:00

Author

Owner

@bluejekyll commented on GitHub (Jun 12, 2018):

yes... but it’s probably going to make fixing this a challenge is my point. The easiest place to do this replacement will be close to serialization time...

Maybe there’s an easy wrapper type that can be placed on all answer records that has the associated query? And that can be used for serialization? It could be applied with a map function on the record set lookup...

@bluejekyll commented on GitHub (Jun 12, 2018): yes... but it’s probably going to make fixing this a challenge is my point. The easiest place to do this replacement will be close to serialization time... Maybe there’s an easy wrapper type that can be placed on all answer records that has the associated query? And that can be used for serialization? It could be applied with a map function on the record set lookup...

kerem commented

2026-03-07 22:50:22 +03:00

Author

Owner

@bluejekyll commented on GitHub (Apr 9, 2019):

Not sure when exactly this was fixed, but original queries are returned in the response now.

@bluejekyll commented on GitHub (Apr 9, 2019): Not sure when exactly this was fixed, but original queries are returned in the response now.

kerem referenced this issue

2026-03-15 22:17:31 +03:00

[GH-ISSUE #211] Add Test for Shutdown and Startup of Server #396

kerem referenced this issue

2026-03-16 01:59:10 +03:00

[PR #215] [MERGED] Properly deal with no SupportedAlgorithms supplied in Request #1305