[PR #215] [MERGED] Properly deal with no SupportedAlgorithms supplied in Request #1305

New issue

Closed

opened 2026-03-16 01:59:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:59:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/215
Author: @bluejekyll
Created: 9/28/2017
Status: ✅ Merged
Merged: 10/3/2017
Merged by: @bluejekyll

Base: master ← Head: fix-non-rsa-signing

📝 Commits (10+)

0f2256e add new testing harness for DNSSec
3d2aaf4 add signing and validation for ed25519
4a92ce2 sha512 test
13cb891 self-sign DNSKEY
4191589 fix tests to pass DAU
a420bc9 ignore rfc6975 when not specified
a9c8b92 clean up some logging
55c4d38 add ecdsa tests
1ea1820 make just openssl ecdsa tests work
0f82471 disable all SHA1 KeyFormats

📊 Changes

24 files changed (+920 additions, -223 deletions)

View changed files

📝 CHANGELOG.md (+6 -0)
📝 client/src/client/client_future.rs (+3 -1)
📝 client/src/rr/dnssec/algorithm.rs (+46 -27)
📝 client/src/rr/dnssec/key_format.rs (+138 -93)
📝 client/src/rr/dnssec/supported_algorithm.rs (+19 -6)
📝 client/src/rr/rr_set.rs (+16 -0)
📝 server/src/authority/authority.rs (+10 -19)
📝 server/src/authority/catalog.rs (+9 -3)
📝 server/src/config.rs (+36 -30)
📝 server/src/named.rs (+12 -4)
➕ server/tests/named_test_configs/all_supported_dnssec.toml (+77 -0)
➕ server/tests/named_test_configs/dnssec/ecdsa_p256.pem (+8 -0)
➕ server/tests/named_test_configs/dnssec/ecdsa_p384.pem (+9 -0)
➕ server/tests/named_test_configs/dnssec/ed25519.pk8 (+0 -0)
➕ server/tests/named_test_configs/dnssec/gen-keys.sh (+18 -0)
➕ server/tests/named_test_configs/dnssec/rsa_2048.pem (+30 -0)
➕ server/tests/named_test_configs/dnssec_with_update.toml (+69 -0)
📝 server/tests/named_test_configs/example.toml (+3 -6)
➕ server/tests/named_test_configs/openssl_dnssec.toml (+71 -0)
📝 server/tests/server_harness/mod.rs (+101 -22)

...and 4 more files

📄 Description

Fixes: #211
Fixes: #212
Fixes: #213
Fixes: #214

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/215 **Author:** [@bluejekyll](https://github.com/bluejekyll) **Created:** 9/28/2017 **Status:** ✅ Merged **Merged:** 10/3/2017 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `master` ← **Head:** `fix-non-rsa-signing` --- ### 📝 Commits (10+) - [`0f2256e`](https://github.com/hickory-dns/hickory-dns/commit/0f2256e331f5096f9e22ec40053c4d6a33ea272c) add new testing harness for DNSSec - [`3d2aaf4`](https://github.com/hickory-dns/hickory-dns/commit/3d2aaf402affb75414a33cea4366137c3e5a5859) add signing and validation for ed25519 - [`4a92ce2`](https://github.com/hickory-dns/hickory-dns/commit/4a92ce22407af25d4b19e5d51aa8104dd3727429) sha512 test - [`13cb891`](https://github.com/hickory-dns/hickory-dns/commit/13cb89171643585dc3c47bb58a6874850133fe4d) self-sign DNSKEY - [`4191589`](https://github.com/hickory-dns/hickory-dns/commit/4191589dcc95a2ca2121874a41dca90de4a39ba6) fix tests to pass DAU - [`a420bc9`](https://github.com/hickory-dns/hickory-dns/commit/a420bc9fb61ffd187d288eeeaba75cca502286b6) ignore rfc6975 when not specified - [`a9c8b92`](https://github.com/hickory-dns/hickory-dns/commit/a9c8b921f42a629366748733a3c9494c34a690e5) clean up some logging - [`55c4d38`](https://github.com/hickory-dns/hickory-dns/commit/55c4d389d9259be8aef265a6f05b0362b10e9501) add ecdsa tests - [`1ea1820`](https://github.com/hickory-dns/hickory-dns/commit/1ea1820df346672cf71bf2f933d75494b1088c0d) make just openssl ecdsa tests work - [`0f82471`](https://github.com/hickory-dns/hickory-dns/commit/0f824711b95188c8483aceab18815ec2e686f248) disable all SHA1 KeyFormats ### 📊 Changes **24 files changed** (+920 additions, -223 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+6 -0) 📝 `client/src/client/client_future.rs` (+3 -1) 📝 `client/src/rr/dnssec/algorithm.rs` (+46 -27) 📝 `client/src/rr/dnssec/key_format.rs` (+138 -93) 📝 `client/src/rr/dnssec/supported_algorithm.rs` (+19 -6) 📝 `client/src/rr/rr_set.rs` (+16 -0) 📝 `server/src/authority/authority.rs` (+10 -19) 📝 `server/src/authority/catalog.rs` (+9 -3) 📝 `server/src/config.rs` (+36 -30) 📝 `server/src/named.rs` (+12 -4) ➕ `server/tests/named_test_configs/all_supported_dnssec.toml` (+77 -0) ➕ `server/tests/named_test_configs/dnssec/ecdsa_p256.pem` (+8 -0) ➕ `server/tests/named_test_configs/dnssec/ecdsa_p384.pem` (+9 -0) ➕ `server/tests/named_test_configs/dnssec/ed25519.pk8` (+0 -0) ➕ `server/tests/named_test_configs/dnssec/gen-keys.sh` (+18 -0) ➕ `server/tests/named_test_configs/dnssec/rsa_2048.pem` (+30 -0) ➕ `server/tests/named_test_configs/dnssec_with_update.toml` (+69 -0) 📝 `server/tests/named_test_configs/example.toml` (+3 -6) ➕ `server/tests/named_test_configs/openssl_dnssec.toml` (+71 -0) 📝 `server/tests/server_harness/mod.rs` (+101 -22) _...and 4 more files_ </details> ### 📄 Description Fixes: #211 Fixes: #212 Fixes: #213 Fixes: #214 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>