[PR #1205] [CLOSED] Clippy fixes #2078

New issue

Closed

opened 2026-03-16 05:34:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 05:34:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1205
Author: @jonasbb
Created: 9/16/2020
Status: ❌ Closed

Base: main ← Head: clippy-fixes

📝 Commits (3)

e2f56d4 Fix some clippy warnings
1396915 Fix clippy::min_max
89866ea Fix clippy::derive_ord_xor_partial_ord

📊 Changes

18 files changed (+66 additions, -116 deletions)

View changed files

📝 bin/src/named.rs (+3 -5)
📝 crates/client/src/serialize/txt/rdata_parsers/openpgpkey.rs (+3 -3)
📝 crates/client/src/serialize/txt/rdata_parsers/tlsa.rs (+2 -2)
📝 crates/client/src/serialize/txt/zone.rs (+1 -1)
📝 crates/client/src/serialize/txt/zone_lex.rs (+1 -1)
📝 crates/https/src/https_server.rs (+1 -1)
📝 crates/https/src/request.rs (+1 -1)
📝 crates/proto/src/error.rs (+1 -4)
📝 crates/proto/src/rr/domain/label.rs (+7 -7)
📝 crates/proto/src/rr/rdata/caa.rs (+8 -39)
📝 crates/proto/src/rr/record_type.rs (+1 -4)
📝 crates/proto/src/rr/resource.rs (+13 -8)
📝 crates/proto/src/rr/rr_set.rs (+1 -4)
📝 crates/proto/src/serialize/binary/restrict.rs (+9 -9)
📝 crates/proto/src/xfer/dns_response.rs (+6 -6)
📝 crates/resolver/src/name_server/name_server_pool.rs (+1 -5)
📝 crates/server/src/authority/error.rs (+3 -12)
📝 crates/server/src/authority/zone_type.rs (+4 -4)

📄 Description

This fixes some clippy warnings.
The first commit contains fixes which are machine applicable.
The second commit fixes a buffer sizing where min and max were switched leading to a constant size.
The last commit fixes a problem with the manual implementation of PartialOrd.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1205 **Author:** [@jonasbb](https://github.com/jonasbb) **Created:** 9/16/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `clippy-fixes` --- ### 📝 Commits (3) - [`e2f56d4`](https://github.com/hickory-dns/hickory-dns/commit/e2f56d457e971199da75d9738c37af55fbbabfb6) Fix some clippy warnings - [`1396915`](https://github.com/hickory-dns/hickory-dns/commit/1396915a045634442a99469b5d88a8664dabc750) Fix clippy::min_max - [`89866ea`](https://github.com/hickory-dns/hickory-dns/commit/89866eacf6ff41d9b82accd188dd1eb297618ad8) Fix clippy::derive_ord_xor_partial_ord ### 📊 Changes **18 files changed** (+66 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `bin/src/named.rs` (+3 -5) 📝 `crates/client/src/serialize/txt/rdata_parsers/openpgpkey.rs` (+3 -3) 📝 `crates/client/src/serialize/txt/rdata_parsers/tlsa.rs` (+2 -2) 📝 `crates/client/src/serialize/txt/zone.rs` (+1 -1) 📝 `crates/client/src/serialize/txt/zone_lex.rs` (+1 -1) 📝 `crates/https/src/https_server.rs` (+1 -1) 📝 `crates/https/src/request.rs` (+1 -1) 📝 `crates/proto/src/error.rs` (+1 -4) 📝 `crates/proto/src/rr/domain/label.rs` (+7 -7) 📝 `crates/proto/src/rr/rdata/caa.rs` (+8 -39) 📝 `crates/proto/src/rr/record_type.rs` (+1 -4) 📝 `crates/proto/src/rr/resource.rs` (+13 -8) 📝 `crates/proto/src/rr/rr_set.rs` (+1 -4) 📝 `crates/proto/src/serialize/binary/restrict.rs` (+9 -9) 📝 `crates/proto/src/xfer/dns_response.rs` (+6 -6) 📝 `crates/resolver/src/name_server/name_server_pool.rs` (+1 -5) 📝 `crates/server/src/authority/error.rs` (+3 -12) 📝 `crates/server/src/authority/zone_type.rs` (+4 -4) </details> ### 📄 Description This fixes some clippy warnings. The first commit contains fixes which are machine applicable. The second commit fixes a buffer sizing where min and max were switched leading to a constant size. The last commit fixes a problem with the manual implementation of `PartialOrd`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>