[PR #40] [CLOSED] Support verification of ECDSA RRSIGs #1205

New issue

Closed

opened 2026-03-16 01:53:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-16 01:53:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/40
Author: @SAPikachu
Created: 8/23/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (4)

f332198 Uncomment ECDSA algorithms
724d791 Wrap PKey into a local enum, so that we can add ECDSA support later
cabeb16 Fix tests
7ea9bc0 Implement serialization of ECDSA keys

📊 Changes

9 files changed (+148 additions, -47 deletions)

View changed files

📝 src/authority/authority.rs (+1 -1)
📝 src/client/client.rs (+1 -1)
📝 src/named.rs (+1 -1)
📝 src/rr/dnssec/algorithm.rs (+115 -23)
📝 src/rr/dnssec/digest_type.rs (+2 -2)
📝 src/rr/dnssec/mod.rs (+1 -1)
📝 src/rr/dnssec/signer.rs (+17 -12)
📝 src/rr/dnssec/supported_algorithm.rs (+8 -4)
📝 src/rr/dnssec/trust_anchor.rs (+2 -2)

📄 Description

This is not ready for merging yet, it lacks the final verification part and I plan to implement that after briansmith/ring#253 is implemented. I am posting here to get some comment on my implementation and see if I missed anything. :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/40 **Author:** [@SAPikachu](https://github.com/SAPikachu) **Created:** 8/23/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`f332198`](https://github.com/hickory-dns/hickory-dns/commit/f332198baede2df59687b3cb2d7f3e2a994a53dc) Uncomment ECDSA algorithms - [`724d791`](https://github.com/hickory-dns/hickory-dns/commit/724d7918e8e091e45e701b192fee9d23a0795827) Wrap PKey into a local enum, so that we can add ECDSA support later - [`cabeb16`](https://github.com/hickory-dns/hickory-dns/commit/cabeb164c2315d6879b7b36bab766593e81dc2e3) Fix tests - [`7ea9bc0`](https://github.com/hickory-dns/hickory-dns/commit/7ea9bc000beb1cacd49377b2bc0a70774fc60e83) Implement serialization of ECDSA keys ### 📊 Changes **9 files changed** (+148 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `src/authority/authority.rs` (+1 -1) 📝 `src/client/client.rs` (+1 -1) 📝 `src/named.rs` (+1 -1) 📝 `src/rr/dnssec/algorithm.rs` (+115 -23) 📝 `src/rr/dnssec/digest_type.rs` (+2 -2) 📝 `src/rr/dnssec/mod.rs` (+1 -1) 📝 `src/rr/dnssec/signer.rs` (+17 -12) 📝 `src/rr/dnssec/supported_algorithm.rs` (+8 -4) 📝 `src/rr/dnssec/trust_anchor.rs` (+2 -2) </details> ### 📄 Description This is not ready for merging yet, it lacks the final verification part and I plan to implement that after briansmith/ring#253 is implemented. I am posting here to get some comment on my implementation and see if I missed anything. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>