[PR #1188] [MERGED] Fix Glue records resolving #2053

Closed
opened 2026-03-16 05:01:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hickory-dns/hickory-dns/pull/1188
Author: @wavenator
Created: 8/12/2020
Status: Merged
Merged: 8/12/2020
Merged by: @bluejekyll

Base: mainHead: main


📝 Commits (1)

  • f951724 NoError error now returns only if answers & additionals & nameservers

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 crates/resolver/src/lookup_state.rs (+5 -0)
📝 crates/resolver/src/name_server/name_server.rs (+5 -1)

📄 Description

NoError error now returns only if answers & additionals & nameservers sections are all empty.
Response records are now chained along with the name_servers section.

fix for #1187


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hickory-dns/hickory-dns/pull/1188 **Author:** [@wavenator](https://github.com/wavenator) **Created:** 8/12/2020 **Status:** ✅ Merged **Merged:** 8/12/2020 **Merged by:** [@bluejekyll](https://github.com/bluejekyll) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`f951724`](https://github.com/hickory-dns/hickory-dns/commit/f951724e3836621503e436b6fb5057a3440aab19) NoError error now returns only if answers & additionals & nameservers ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/resolver/src/lookup_state.rs` (+5 -0) 📝 `crates/resolver/src/name_server/name_server.rs` (+5 -1) </details> ### 📄 Description NoError error now returns only if answers & additionals & nameservers sections are all empty. Response records are now chained along with the name_servers section. fix for #1187 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-16 05:01:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#2053
No description provided.