starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00

[GH-ISSUE #490] Add (optional) serde support for types in trust_dns_resolver::config #205

New issue

Closed

opened 2026-03-07 22:47:51 +03:00 by kerem · 6 comments

kerem commented

2026-03-07 22:47:51 +03:00

Owner

Originally created by @kingoflolz on GitHub (May 25, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/490

Hi,

I am building an application which will use trust-dns-resolver and I would like to have a config file where the user can specify which DNS server to use. Adding serde as an optional dependency and optionally deriving Serialize and Deserialize on the config types would make this much easier. Is this something that you would be interested in adding?

I would be happy to provide a PR for this.

Thanks

Originally created by @kingoflolz on GitHub (May 25, 2018). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/490 Hi, I am building an application which will use trust-dns-resolver and I would like to have a config file where the user can specify which DNS server to use. Adding serde as an optional dependency and optionally deriving Serialize and Deserialize on the config types would make this much easier. Is this something that you would be interested in adding? I would be happy to provide a PR for this. Thanks

kerem closed this issue

2026-03-07 22:47:56 +03:00

kerem commented

2026-03-07 22:48:02 +03:00

Author

Owner

@bluejekyll commented on GitHub (May 25, 2018):

I'd prefer to not pull a dependency on Serde right now, to be clear, we are trying to keep the number of dependencies in the Resolver limited so that it fits with various use cases where there is a desire to have a small set of dependencies, in fact there are probably many that we should be considering for removal.

It's possible this might work: https://serde.rs/remote-derive.html

Something along the lines of:

#[derive(Serialize, Deserialize)]
struct TrustDnsConfig(ResolverConfig);

See how far that gets you... If that's successful, we could add another crate for Serde derived configurations to help people in similar situations.

@bluejekyll commented on GitHub (May 25, 2018): I'd prefer to not pull a dependency on Serde right now, to be clear, we are trying to keep the number of dependencies in the Resolver limited so that it fits with various use cases where there is a desire to have a small set of dependencies, in fact there are probably many that we should be considering for removal. It's possible this might work: https://serde.rs/remote-derive.html Something along the lines of: ```rust #[derive(Serialize, Deserialize)] struct TrustDnsConfig(ResolverConfig); ``` See how far that gets you... If that's successful, we could add another crate for Serde derived configurations to help people in similar situations.

kerem commented

2026-03-07 22:48:07 +03:00

Author

Owner

@kingoflolz commented on GitHub (May 26, 2018):

@bluejekyll using remote derive should work, but I think it will be better to build serde support in so it would be more seamless. We can use a cargo feature to ensure there are no additional deps by default, and people who need it can opt into using serde.

@kingoflolz commented on GitHub (May 26, 2018): @bluejekyll using remote derive should work, but I think it will be better to build serde support in so it would be more seamless. We can use a cargo feature to ensure there are no additional deps by default, and people who need it can opt into using serde.

kerem commented

2026-03-07 22:48:12 +03:00

Author

Owner

@bluejekyll commented on GitHub (May 26, 2018):

@briansmith, I think you’d have the biggest concern here...

@bluejekyll commented on GitHub (May 26, 2018): @briansmith, I think you’d have the biggest concern here...

kerem commented

2026-03-07 22:48:18 +03:00

Author

Owner

@briansmith commented on GitHub (May 26, 2018):

@briansmith, I think you’d have the biggest concern here...

I don't have a good answer. If this were my project I would probably wouldn't do it, just due to lack of time to fully think through all the implications of doing it.

@briansmith commented on GitHub (May 26, 2018): > @briansmith, I think you’d have the biggest concern here... I don't have a good answer. If this were my project I would probably wouldn't do it, just due to lack of time to fully think through all the implications of doing it.

kerem commented

2026-03-07 22:48:23 +03:00

Author

Owner

@bluejekyll commented on GitHub (May 26, 2018):

Thanks, @briansmith.

@kingoflolz there is this issue: #483, which may be of interest. I think that might end up needing some serde derivable configs as well. I did add this to the server crate. My concern is that with the resolver we want to keep the dependencies slim as we want it to be able to be embedded in many different contexts, and config files would generally only be for binaries.

I suppose if we keep this as optional, and off by default, then that would be ok, though I am curious what it would look like to have a separate crate for this glue...

@bluejekyll commented on GitHub (May 26, 2018): Thanks, @briansmith. @kingoflolz there is this issue: #483, which may be of interest. I think that might end up needing some serde derivable configs as well. I did add this to the server crate. My concern is that with the resolver we want to keep the dependencies slim as we want it to be able to be embedded in many different contexts, and config files would generally only be for binaries. I suppose if we keep this as optional, and off by default, then that would be ok, though I am curious what it would look like to have a separate crate for this glue...

kerem commented

2026-03-07 22:48:28 +03:00

Author

Owner

@kingoflolz commented on GitHub (May 27, 2018):

@bluejekyll Thanks for your reply, I'll create a PR adding it as an optional feature to structs in trust-dns-resolver::conf::* (at least for now), and I'll make it off by default.

P.S. Serde provides external derives which alleviate most of the issue, however, they are less ergonomic to use (have to specify a #[serde(with = "")] every time its (de)/serialized)

@kingoflolz commented on GitHub (May 27, 2018): @bluejekyll Thanks for your reply, I'll create a PR adding it as an optional feature to structs in trust-dns-resolver::conf::* (at least for now), and I'll make it off by default. P.S. Serde provides external derives which alleviate most of the issue, however, they are less ergonomic to use (have to specify a #[serde(with = "")] every time its (de)/serialized)

kerem referenced this issue

2026-03-15 22:13:44 +03:00

[GH-ISSUE #180] When *ring* feature is enabled, use it for RSA and other supported DNSSec proofs #384

kerem referenced this issue

2026-03-15 22:15:27 +03:00

[GH-ISSUE #205] Create Proto crate: better SoC for Signer/Verifier, KeyPair/PublicKey, etc. #389