mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #423] It should be possible to use a single DNS configuration/options object for multiple lookups #483
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#483
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @briansmith on GitHub (Apr 24, 2018).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/423
My application reads the configuration files (/etc/resolv.conf, /etc/hosts, etc.) using
trust_dns_resolver::system_conf::read_system_conf()once at startup. I'd like to reuse the config/opts objects it returns for multiple asynchronous lookups. However,ResolverFuture::new()uses move semantics for itsconfigandoptionsarguments. I think it would be better to haveResolverFuture::new()takeRc<>sinstead.@bluejekyll commented on GitHub (Apr 24, 2018):
I'm guessing this means that in your use case the resolver is not long lived. I think this is fine. Right now ResolverOpts is fairly cheap, so that's copy. Right now, there are some restrictions on ResolverFuture, which I think will require
Arc. Any issue with that?@bluejekyll commented on GitHub (Apr 25, 2018):
Out of curiosity, why not keep the ResolverFuture itself around instead just the Config? Is there a concern with that?
@briansmith commented on GitHub (Apr 26, 2018):
I agree that I should just reuse the
ResolverFuture, but it is unclear if I can correctly do so in my project until #430 is resolved. I'm going to close this and I think PR #424 should be closed too,